Update secc interface and simulator #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…override them in the simulator.
tropxy
reviewed
Feb 18, 2022
|
Together with @tropxy we decided to just remove the create method from the simulator.py and interface.py. |
tropxy
reviewed
Feb 18, 2022
iso15118/secc/secc_settings.py
Outdated
| @@ -50,10 +49,6 @@ def load_envs(self, env_path: Optional[str] = None) -> None: | |||
|
|
|||
There was a problem hiding this comment.
we shall also remove the redis host and port settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a small PR for this two files before I open a bigger one to align with Shalin's latest changes.