AB#3740: Removed check in SalesTariff validator #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tropxy
approved these changes
Jan 26, 2023
shalinnijel2
force-pushed
the
remove_price_level_count_check
branch
from
81a46d2 to
39612b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
NumEPriceLevels is the distinct price levels used across all SalesTariff entries.
The validation assumed that NumEPriceLevels would be equal to the count of SalesTariff entries. This would be true only if every SalesTariff entry has as different price level. As the same price level could apply to two different SalesTariff entry, this check could wrongly fail the validation. Have removed the check. This issue was reported here.