Feature/dc states till session stop

[lukaslombriserdesignwerk]

No description provided.

[tropxy]

First my sincere apologies for not reviewing this earlier, but as I suspected, it took me a considerable amount of time, time that it has been hard to get lately.

That said, thank you so much for this great contribution, it really makes us happy to see how fast and well you understood the code architecture and provided such good quality. There are quite a few notes that I have left and that we need to discuss, so please check them and take your time and come back to me if you have any questions.

Cheers ;)

[tropxy]

Lukas I think you havent pushed your last changes. can you check that?
Also you need to rebase your code against master

[shalinnijel2]

Hi Lukas, main now has the fix for the issue you commented about WeldingDetectionRes exi encoding failing as well.

[shalinnijel2]

The make file has flake8 and black utilities to help with formatting.
make flake8
make black
black iso15118/

[lukaslombriserdesignwerk]

Hi Lukas, main now has the fix for the issue you commented about WeldingDetectionRes exi encoding failing as well.

Thank you Shalin. Now it's working.

[tropxy]

cool stuff, thanks for the improvements

[tropxy]

oh no, that I got it and is fine, I meant the set_ev_soc, why do we need that method here?

[tropxy]

A few more notes ;)

[tropxy]

I see...I think we should have a structure that holds the current EV information, like present current, present voltage, SoC and here as an example, we would call update_ev_data(soc=cable_check_req.dc_ev_status.ev_ress_soc)
Then, the method updates some data structure like a dataclass:

@daclass
class ev_data_context:
    dc_current: Optional[int] = None
    dc_voltage: Optional[int] = None
    ac_current: Optional[dict] = None # {"l1": 10, "l2": 10, "l3": 10}
    ac_voltage: Optional[dict] = None # {"l1": 230, "l2": 230, "l3": 230}
    soc: Optional[int] = None # 0-100

the method would accept more arguments which would be optional
what do you think?

[lukaslombriserdesignwerk]

I don't know why, but I can't comment the conversation about the set_soc function.

i made a dataclass ev_data_context and a method update_ev_data. Is it how you figured?
But I think in DC-Charging we just use the SOC, because we already know the current and voltage from the EVSE.
And I also checked the ChargingStatusReq Message for AC charging. In this message no EV information are provided.

What do you think?

[lukaslombriserdesignwerk]

A few more improvements :)

[tropxy]

I don't know why, but I can't comment the conversation about the set_soc function.

i made a dataclass ev_data_context and a method update_ev_data. Is it how you figured? But I think in DC-Charging we just use the SOC, because we already know the current and voltage from the EVSE. And I also checked the ChargingStatusReq Message for AC charging. In this message no EV information are provided.

What do you think?

Yes, I think there are some bugs in Github recently and prevent comments in certain spots.
Regarding your approach: yes, that is more or less how I figured it out; for AC charging I am aware there is no way to get the SoC, but that is ok, that is why in my example I added the fields as Optional

[tropxy]

just added a few more notes

[lukaslombriserdesignwerk]

Hi André

I did some improvements.
And I also reformated the code to fullfill flake8 and black.
But here it looks like code-quality-check is still not passed (I don't know if it has something to do with black and flake8).

From tomorrow till easter I'll be on holidays. If you have any questions Martin is the man.

And until tomorrow morning, I could also do some improvements for the pullrequests :)

[tropxy]

Hi André

I did some improvements. And I also reformated the code to fullfill flake8 and black. But here it looks like code-quality-check is still not passed (I don't know if it has something to do with black and flake8).

From tomorrow till easter I'll be on holidays. If you have any questions Martin is the man.

And until tomorrow morning, I could also do some improvements for the pullrequests :)

Hi Lukas, I have fixed the code quality and the tests of the code.
I had to do some changes on how we create the EXI instance to make the code pass, but it works now.

I think this code can be merged now ;)

Just need to figure out why are not the CI/CD job running in this PR