JTT-81 Feat: Check response code #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tropxy
approved these changes
Aug 16, 2023
Comment on lines
+981
to
+995
| response_code = ( | ||
| resp_status | ||
| if resp_status | ||
| in [ | ||
| ResponseCode.OK, | ||
| ResponseCode.FAILED, | ||
| ResponseCode.FAILED_SEQUENCE_ERROR, | ||
| ResponseCode.FAILED_SIGNATURE_ERROR, | ||
| ResponseCode.FAILED_UNKNOWN_SESSION, | ||
| ResponseCode.FAILED_CERTIFICATE_EXPIRED, | ||
| ResponseCode.FAILED_CERTIFICATE_REVOKED, | ||
| ResponseCode.FAILED_NO_CERTIFICATE_AVAILABLE, | ||
| ] | ||
| else ResponseCode.FAILED | ||
| ) |
There was a problem hiding this comment.
This could potentially change in an upcoming update to the spec based on the ticket here: https://iso15118.elaad.io/pt2/15118-2/user-group/-/issues/38
Also André has opened a ticket for a better response code when chain error occurs here: https://iso15118.elaad.io/pt2/15118-2/user-group/-/issues/41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a status code verification before sending the response, as the compatibility might be affected by the state being transmitted.
Note:
This limitation arises from the definition of the status response code and its alignment with Table 112 in iso15118-2, which constrains the response to match its corresponding state.