Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for choosing PnC and DIN removal when the connection is non-TLS #367

Merged
merged 2 commits into from
Feb 6, 2024
Merged

Fix for choosing PnC and DIN removal when the connection is non-TLS #367

merged 2 commits into from
Feb 6, 2024

Conversation

anudeep-20
Copy link
Contributor

No description provided.

@shalinnijel2 shalinnijel2 force-pushed the anudeep-20/bug-fix/tls branch from 237bfbc to 09f30b9 Compare January 19, 2024 13:36
shalinnijel2
shalinnijel2 suggested changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@shalinnijel2 shalinnijel2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment. The rest lgtm.

@anudeep-20 anudeep-20 force-pushed the anudeep-20/bug-fix/tls branch 2 times, most recently from ac4abe1 to 5562432 Compare January 19, 2024 23:30
@shalinnijel2 shalinnijel2 force-pushed the anudeep-20/bug-fix/tls branch from 5562432 to e300385 Compare January 22, 2024 07:10
@shalinnijel2
Copy link
Contributor

@anudeep-20 - I see the file formatting has failed (the comment has exceeded 88 chars limit per line). Could you run the following commands in the repo and fix any errors.

make flake8
make black
make reformat

@anudeep-20 anudeep-20 force-pushed the anudeep-20/bug-fix/tls branch from e300385 to b6b57d4 Compare February 1, 2024 09:12
@anudeep-20 anudeep-20 force-pushed the anudeep-20/bug-fix/tls branch from b6b57d4 to a893b38 Compare February 1, 2024 09:24
@shalinnijel2
Copy link
Contributor

Hi @anudeep-20 - merging this change. Thank you for the PR. :)

@shalinnijel2 shalinnijel2 merged commit 1a9260a into EcoG-io:master Feb 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shalinnijel2 shalinnijel2 shalinnijel2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anudeep-20 @shalinnijel2