Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simulate soc in -2, -20 and din. #393

Merged
merged 10 commits into from
Apr 17, 2024
Merged

Simulate soc in -2, -20 and din. #393

merged 10 commits into from
Apr 17, 2024

Conversation

shalinnijel2
Copy link
Contributor

@shalinnijel2 shalinnijel2 commented Apr 3, 2024 •
edited
Loading

Simulate soc in -2, -20 and din.

@shalinnijel2 shalinnijel2 force-pushed the jtt_845_remove_3s_contactor_timeout_dc branch from 860b992 to e565bec Compare April 16, 2024 09:08
@shalinnijel2 shalinnijel2 marked this pull request as ready for review April 16, 2024 09:08
@shalinnijel2 shalinnijel2 changed the title Move contactor close check to be after cable check is complete. Simulate soc in -2, -20 and din. Apr 17, 2024
ikaratass
ikaratass approved these changes Apr 17, 2024
View reviewed changes
Copy link
Collaborator

@ikaratass ikaratass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@shalinnijel2 shalinnijel2 merged commit 868f704 into master Apr 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikaratass ikaratass ikaratass approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shalinnijel2 @ikaratass