Make communication protocols configurable via .env file #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tropxy
requested changes
Jun 12, 2022
|
Dont forget to modify the README as well with the new ENV |
Sure, done. |
|
rebase the branch and I think is good to go |
fix: Addressed comments in PR(AB#2179) fix: Fixed formatting errors(AB#2179) Updated readme to reflect the newly added env variables.
shalinnijel2
force-pushed
the
configurable_communication_protocols
branch
from
a1dfe9d to
b062349
Compare
tropxy
approved these changes
Jun 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified secc_settings.py to read protocols and auth_modes from .env file if set.
If not set, then would default to all supported protocols.
This mod only applies to secc_settings - evcc protocol preferences are still hardcoded in evcc_settings.py
This would help test other use cases like evcc having different protocol priorities to secc.
The env variable is added and left commented out in the .env.dev.local and .env.dev.docker file to hint that configuring protocols is possible.