-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Effect imports #48
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 18db525 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
9976eb2
to
16f3768
Compare
16f3768
to
554570c
Compare
…rvice plugin, fix examples and tsconfig
…ntional formatting in examples. Fixed tests. Refactored asyncAwaitToGen to work with current Effect API. Added plugin option `preferredEffectGenAdapterName`
I think this PR should be ready to go now, pending a review from @mattiamanzati |
fubhy
approved these changes
Dec 8, 2023
IMax153
approved these changes
Dec 8, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves
Effect
imports, removing support for detection of imports from@effect/io
in favour of fromeffect
.The current version only supports detecting namespace imports.
With this PR, named imports are also supported:
Detection of namespace imports and named imports from
effect
is done statically using the AST.If no namespace or named import can be found, a further check for re-exports is made using the typechecker, where the
exports
of each imported module is checked to see if there's an entry in the map with keyEffect
.So given
reExport.ts
:then
Eff
(asEffect
) is correctly detected: