m: Cppcheck

block.cpp

@@ -237,7 +237,7 @@ void Block::moveBlock(const bool bRelease) {
 
 void Block::rotateBlock(const int nDelta) {
   static const quint8 RIGHTANGLE = 90;
-  if (m_bActive || !this->isAnyBlockActive()) {
+  if (m_bActive || !this->isAnyBlockActive(m_pListBlocks)) {
     qint8 nAngle(0);
     qreal nTranslateX(0);
     qreal nTranslateY(0);
@@ -260,7 +260,7 @@ void Block::rotateBlock(const int nDelta) {
     // qDebug() << "After rot.:" << m_PolyShape;
   }
 
-  if (!this->isAnyBlockActive()) {
+  if (!this->isAnyBlockActive(m_pListBlocks)) {
     this->checkBlockIntersection();
   }
 }
@@ -269,7 +269,7 @@ void Block::rotateBlock(const int nDelta) {
 // ---------------------------------------------------------------------------
 
 void Block::flipBlock() {
-  if (m_bActive || !this->isAnyBlockActive()) {
+  if (m_bActive || !this->isAnyBlockActive(m_pListBlocks)) {
     this->prepareGeometryChange();
     // qDebug() << "Before flip" << m_nID << "-" << m_PolyShape;
     QTransform transform = QTransform::fromScale(-1, 1);
@@ -278,7 +278,7 @@ void Block::flipBlock() {
     // qDebug() << "After flip:" << m_PolyShape;
   }
 
-  if (!this->isAnyBlockActive()) {
+  if (!this->isAnyBlockActive(m_pListBlocks)) {
     this->checkBlockIntersection();
   }
 }
@@ -390,8 +390,8 @@ void Block::rescaleBlock(const quint16 nNewScale) {
 // ---------------------------------------------------------------------------
 // ---------------------------------------------------------------------------
 
-auto Block::isAnyBlockActive() -> bool {
-  for (auto &pBlock : *m_pListBlocks) {
+auto Block::isAnyBlockActive(const QList<Block *> *listBlocks) -> bool {
+  for (const auto pBlock : *listBlocks) {
     if (pBlock->isActive()) {
       return true;
     }

block.h

@@ -82,7 +82,7 @@ class Block : public QGraphicsObject {
   void checkBlockIntersection();
   auto snapToGrid(const QPointF point) const -> QPointF;
   void resetBrushStyle() const;
-  auto isAnyBlockActive() -> bool;
+  auto isAnyBlockActive(const QList<Block *> *listBlocks) -> bool;
 
   void moveBlock(const bool bRelease = false);
   void rotateBlock(const int nDelta = -1);

board.cpp

@@ -197,7 +197,7 @@ auto Board::setupBlocks() -> bool {
 
 auto Board::createBlocks() -> bool {
   const quint8 nMaxNumOfBlocks(250);
-  QSettings *tmpSet = m_pBoardConf;
+  const QSettings *tmpSet = m_pBoardConf;
   if (m_bSavedGame) {
     tmpSet = m_pSavedConf;
   }
@@ -321,7 +321,6 @@ auto Board::readColor(const QString &sKey,
 
 auto Board::readPolygon(const QSettings *tmpSet, const QString &sKey,
                         const bool bScale) -> QPolygonF {
-  QStringList sList;
   QStringList sListPoint;
   QString sValue(tmpSet->value(sKey, "").toString());
   quint16 nScale(1);
@@ -330,10 +329,10 @@ auto Board::readPolygon(const QSettings *tmpSet, const QString &sKey,
   }
 
   Board::checkOrthogonality(QPointF(-99999, -99999));
-  sList << sValue.split('|');
+  const QStringList sList(sValue.split('|'));
   QPolygonF polygon;
   polygon.reserve(sList.size());
-  for (auto &s : sList) {
+  for (const auto &s : sList) {
     sListPoint.clear();
     sListPoint << s.split(',');
     if (2 == sListPoint.size()) {

boardselection.cpp

@@ -74,10 +74,9 @@ BoardSelection::BoardSelection(QWidget *pParent, const QString &sBoardsDir,
     int nRow = 0;
     quint16 nSolved = 0;
     quint16 nSum = 0;
-    bool bSolved;
     for (const auto &board : boardfiles) {
       QString sFile(sSubfolder + "/" + board);
-      bSolved = !m_sListAllUnsolved.contains(sFile);
+      bool bSolved = !m_sListAllUnsolved.contains(sFile);
       m_pListBoards << new BoardPreview(m_sBoardsDir + "/" + sFile, bSolved,
                                         m_previewsize);
       m_pListTabLayouts.last()->addWidget(m_pListBoards.last(), nRow, nCol);