-
Notifications
You must be signed in to change notification settings - Fork 123
[FLOSS T1] Change checking of stale issues/PRs to GitHub action #4695
Conversation
@markus2330 Are you ok with that?
If so, then please do the switch as you announced in #4476 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, let us see if it works.
name: Close inactive issues and PRs | ||
on: | ||
schedule: | ||
- cron: "30 1 * * *" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which timezone is this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fear this is undefined when using GitHub runners.
There is an issue where others have requested the possibility of setting a timezone: actions/runner#1423
If this is important, I could do further research.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, not important.
issues: write | ||
pull-requests: write | ||
steps: | ||
- uses: actions/stale@v5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any specific reason why you didn't use the latest version (v6.0.1)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No reason. I adopted the code from https://docs.github.com/en/actions/managing-issues-and-pull-requests/closing-inactive-issues.
As discussed in #4476 there is an additional step required when removing the old configuration. There @stefnotch did the research on how to carry out the swtich from probot/stale to the GitHub action.
One notable difference to the previous setup is that the check would now only run daily. (It is straightforward to change this by modifying the cron job configuration.)
Afaict, the cron job would run on a runner from GitHub.
Closes #4476
Basics
(added as entry in
doc/news/_preparation_next_release.md
whichcontains
_(my name)_
)Please always add something to the release notes.
(first line should have
module: short statement
syntax)close #X
, are in the commit messages.doc/news/_preparation_next_release.md
scripts/dev/reformat-all
Checklist
(not in the PR description)
Review
Labels