Skip to content
This repository has been archived by the owner on Oct 15, 2024. It is now read-only.

[FLOSS T1] Change checking of stale issues/PRs to GitHub action #4695

Merged
merged 2 commits into from
Nov 28, 2022

Conversation

0x6178656c
Copy link
Contributor

@0x6178656c 0x6178656c commented Nov 20, 2022

As discussed in #4476 there is an additional step required when removing the old configuration. There @stefnotch did the research on how to carry out the swtich from probot/stale to the GitHub action.

One notable difference to the previous setup is that the check would now only run daily. (It is straightforward to change this by modifying the cron job configuration.)

Afaict, the cron job would run on a runner from GitHub.

Closes #4476

Basics

  • Short descriptions of your changes are in the release notes
    (added as entry in doc/news/_preparation_next_release.md which
    contains _(my name)_)
    Please always add something to the release notes.
  • Details of what you changed are in commit messages
    (first line should have module: short statement syntax)
  • References to issues, e.g. close #X, are in the commit messages.
  • The buildservers are happy. If not, fix in this order:
    • add a line in doc/news/_preparation_next_release.md
    • reformat the code with scripts/dev/reformat-all
    • make all unit tests pass
    • fix all memleaks
  • The PR is rebased with current master.

Checklist

  • I added unit tests for my code
  • I fully described what my PR does in the documentation
    (not in the PR description)
  • I fixed all affected documentation (see Documentation Guidelines)
  • I fixed all affected decisions (see Decision Process)
  • I added code comments, logging, and assertions as appropriate (see Coding Guidelines)
  • I updated all meta data (e.g. README.md of plugins and METADATA.ini)
  • I mentioned every code not directly written by me in reuse syntax

Review

Labels

  • Add the "work in progress" label if you do not want the PR to be reviewed yet.
  • Add the "ready to merge" label if the basics are fulfilled and no further pushes are planned by you.

@flo91 flo91 added the T1 label Nov 28, 2022
@flo91
Copy link
Collaborator

flo91 commented Nov 28, 2022

@markus2330 Are you ok with that?

One notable difference to the previous setup is that the check would now only run daily.

If so, then please do the switch as you announced in #4476 (comment)

@markus2330 markus2330 merged commit 0bfb362 into ElektraInitiative:master Nov 28, 2022
Copy link
Contributor

@markus2330 markus2330 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let us see if it works.

name: Close inactive issues and PRs
on:
schedule:
- cron: "30 1 * * *"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which timezone is this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fear this is undefined when using GitHub runners.

There is an issue where others have requested the possibility of setting a timezone: actions/runner#1423

If this is important, I could do further research.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, not important.

issues: write
pull-requests: write
steps:
- uses: actions/stale@v5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any specific reason why you didn't use the latest version (v6.0.1)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mpranj mpranj added this to the 0.9.12 milestone Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FLOSS] Switch from probot/stale to github/stale
4 participants