Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .NET client generator #5201

Closed

Commits on Apr 22, 2022

  1. Add fsharp generators to msggen

    msggen now produces F# request/response from schema.json
    files in a similar way to rust.
    joemphilips committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    3694807 View commit details
    Browse the repository at this point in the history
  2. stop using version in fsharp generators.

    `importlib.metadata` is only usable in python 3.8+
    And using backport described in python-poetry/poetry#273 (comment)
    will cause following error in CI.
    > "importlib_metadata.PackageNotFoundError: No package metadata was found for msggen"
    
    So lets just keep it simple by not having version information in genrated code.
    joemphilips committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    1ad422d View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2022

  1. adjust F# client generation into reusable style

    According to the conversation in ElementsProject#5201,
    generated code for 3rd-party generater should not reside in this repository.
    Instead, only generators under `msggen` should be included.
    
    This commit adjusts F# generator to follow the following rule of thumb.
    
    1. no native F# code, only generators, so every primitives are now reside in `msggen/fsharp.py` with plain text.
    2. no object equivalent to `RPCClient`, only DTOs must be generated. Implementing client is now the consumers duty.
    joemphilips committed Apr 23, 2022
    Configuration menu
    Copy the full SHA
    6376342 View commit details
    Browse the repository at this point in the history