Vllm get tokenizer #1794
Open
Vllm get tokenizer #1794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AguirreNicolas
requested review from
haileyschoelkopf and
lintangsutawika
as code owners
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
It is possible to change the model names served by
vllm, and then have it not respond to any Huggingface repository making it impossible to obtain the tokenizer and therefore runlm-eval-harness.Features:
This PR works in conjunction with another PR in the vllm repository to enable such features. The
vllmserver (optionally for whoever runs it) will send the*.jsongenerated after usingtokenizer.save_pretrained()and then the tokenizer is instantiated locally.When running the tests, simply add the
tokenizer_backend=vllmoption to the model arguments.