Do not retrieve the auth-token on every call #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alejanderl
force-pushed
the
alj/avoid_get_token_on_every_request
branch
from
0f96d69 to
33d9b50
Compare
alejanderl
changed the title
alejanderl
force-pushed
the
alj/avoid_get_token_on_every_request
branch
from
1d8a411 to
50254d9
Compare
Moritz030
reviewed
Aug 10, 2023
| describe '#retrieve_access_token' do | ||
| subject { described_class.call } | ||
|
|
||
| it 'sends request to token endpoint' do |
There was a problem hiding this comment.
But they are in the cassette:
spec/vcr/icd/api/authorize_token.yml
So the vcr_cassette contains the right URL and also the response payload.
Moritz030
reviewed
Aug 10, 2023
Moritz030
reviewed
Aug 10, 2023
Moritz030
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEV-717
This PR fixes retrieving one auth token on every request, so using the TTL of the token to reuse the valid one.
This will reduce by half the response time for medical conditions search