-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ::{{closure}}
in more cases from function names
#230
Conversation
::{{closure}}
in more cases from function names
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this always remove the closure tag? I wonder if we may wanna keep some way of referring to if there is a closure or not. Perhaps this could be a metadata information when hovering over the frame.
I haven't tested how this looks with more closure examples. But can try it out more. Regarding the function to have something come up as a closure, personally I would rather see a name then a generic closure tag, though I cannot say that I'm a heavy user of profiling scopes 🙈 This PR was more a fix for the odd name in the examples then any new functionality. |
I did sanity check the code and it does behave as advertised, removing all mentions of If you then profile a closure and use |
Makes sense to me for ppl to use scopes in this case 👍 |
We may wanna add that to the docstring of |
Yeah make sense, I did update the documentation now. Though I realize now with the change in documentation the eframe example does not adhere to this standard as it uses the |
Checklist
Description of Changes
This removes all
::{{closure}}
from the suffix of a function name when cleaning the name. Previously this was limited to 2.This is noticeable with the changes made in #225 where the
main function
being labeled asmain::{{closure}}
Before
After