[Performance] Use interner to de-duplicate strings #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When reading the profile, many strings are encountered multiple times. Use `String.interner()` to reduce the memory requirements of running the analyzer. Benchmark with a Bazel profile of unzipped size 357MB Using YourKit as a profiler and checking the shallow size just before generating the suggestions: Before: 692 MB After: 349 MB Signed-off-by: Sara Adams <[email protected]>
saraadams
requested review from
WillEngFlow
and removed request for
WillEngFlow
WillEngFlow
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reading the profile, many strings are encountered multiple times. Use
String.interner()to reduce the memory requirements of running the analyzer.Benchmark with a Bazel profile of unzipped size 357MB Using YourKit as a profiler and checking the shallow size just before generating the suggestions:
Before: 692 MB
After: 349 MB
Progress on #163