ci: fix build-docker job to still run when secrets not set/available

[ErikBjare]

Important

Adds conditional logic to build-docker job in build.yml to control Docker image pushing based on branch or tag.

• Behavior:
  • Adds SHOULD_PUSH environment variable to build-docker job in build.yml to determine if Docker images should be pushed.
  • Conditional execution of Docker login and push steps based on SHOULD_PUSH value.
• Workflow:
  • Modifies Log in to GitHub Container Registry and Push Docker image (base) steps to run only if SHOULD_PUSH is true.
  • Updates push parameter in Build and push Docker image (eval) step to use SHOULD_PUSH.

^{This description was created by for 170e4e4. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 170e4e4 in 41 seconds

More details

• Looked at 60 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 2 drafted comments based on config settings.

1. .github/workflows/build.yml:91

• Draft comment:
  The if condition should use ${{ }} for expressions. Use if: ${{ env.SHOULD_PUSH == 'true' }} instead.
• Reason this comment was not posted:
  Decided after close inspection that this draft comment was likely wrong and/or not actionable:
  The current syntax if: env.SHOULD_PUSH == 'true' is valid in GitHub Actions. The suggestion to use ${{ }} is not necessary as the current syntax works correctly. The comment does not point out a required change, as both syntaxes are acceptable.
  I might be missing some specific context where using ${{ }} is preferred or required, but generally, both syntaxes are valid. The comment does not provide strong evidence that a change is needed.
  Even if there is a preference for using ${{ }}, the current syntax is not incorrect, and the comment does not indicate a necessary change. The comment is more of a suggestion than a requirement.
  The comment should be deleted as it does not indicate a necessary change. The current syntax is valid and functional.

2. .github/workflows/build.yml:135

• Draft comment:
  The push parameter should use ${{ }} for expressions. Use push: ${{ env.SHOULD_PUSH == 'true' }} instead. This issue is also present in the push parameter on line 112.
• Reason this comment was not posted:
  Decided after close inspection that this draft comment was likely wrong and/or not actionable:
  The comment suggests a change to the syntax used for the push parameter. The current syntax push: ${{ env.SHOULD_PUSH }} is already using ${{ }} for the expression, which is correct. The suggestion to use push: ${{ env.SHOULD_PUSH == 'true' }} is unnecessary because env.SHOULD_PUSH is already a boolean expression. The comment about line 112 is irrelevant because it uses a static value false, not an expression.
  I might be missing some context about why the comment suggests using == 'true'. However, the current usage seems correct and the suggestion seems redundant.
  The current usage of push: ${{ env.SHOULD_PUSH }} is a standard way to handle boolean expressions in GitHub Actions, and the suggestion to add == 'true' is not necessary.
  The comment is not useful because the current syntax is correct and the suggestion is redundant. The comment should be deleted.

Workflow ID: wflow_eEVnqwfHCDlRzhTn

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.58%. Comparing base (66c977c) to head (170e4e4).

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #255   +/-   ##
=======================================
  Coverage   71.58%   71.58%           
=======================================
  Files          61       61           
  Lines        3952     3952           
=======================================
  Hits         2829     2829           
  Misses       1123     1123           

Flag	Coverage Δ
anthropic/claude-3-haiku-20240307	70.62% <ø> (ø)
openai/gpt-4o-mini	70.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.