Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix js error on any page other than Profile #289

Merged
merged 1 commit into from
Mar 27, 2022

Conversation

fpellet
Copy link
Contributor

@fpellet fpellet commented Mar 25, 2022

inlineAttachment dependencies isn't load on any page other than Profile.
But if avatarUploadsEnabledBool is true, then scoold.js try to initialize upload.

This PR disable avatarUploadsEnabledBool to avoid error on any page other than Profile.

PR Checklist

  • I have read the CONTRIBUTING document.
  • I checked to ensure there aren't other open Pull Requests or issues on the same topic?
  • I have updated the documentation accordingly (if necessary at all).
  • My code follows the code style of this project and does not alter whitespace formatting.
  • My pull request does not introduce features which are already implemented in Scoold Pro.

Large PRs with changes to more than 20 files are strongly discouraged but will be reviewed.

@albogdano albogdano merged commit 9ecae83 into Erudika:master Mar 27, 2022
@fpellet fpellet deleted the fix-inlineAttachment branch April 16, 2022 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants