Skip to content
This repository has been archived by the owner on Aug 15, 2023. It is now read-only.

Local source #280

Merged
merged 3 commits into from
Aug 12, 2020
Merged

Local source #280

merged 3 commits into from
Aug 12, 2020

Conversation

gavinr
Copy link
Contributor

@gavinr gavinr commented Aug 11, 2020

  • Introduces a new property localSourceUrl, which will allow a developer to set where the local esri-leaflet-debug.js file is hosted on their machine.
  • Recommended instructions for the above process was added to the README.
  • Removed the editing.hbs (this was not linked from anywhere, as far as I can tell) and indoors.hbs (dependencies on old/unmaintained packages -- I will move this to a codepen example) examples so that I could ....
  • Removed page.data.legacyLeaflet and page.data.legacyEsriLeaflet which drastically simplified header.hbs and example.hbs

Closes #279

@gavinr gavinr requested a review from jwasilgeo August 11, 2020 20:51
Copy link
Contributor

@jwasilgeo jwasilgeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it, looks great! Good idea on how to handle this situation and the README makes it easy to try it out. Thanks @gavinr.

@jwasilgeo jwasilgeo merged commit d26c7c2 into master Aug 12, 2020
@jwasilgeo jwasilgeo deleted the local-source branch August 12, 2020 12:15
@jgravois
Copy link
Contributor

looks like they're getting that indoor plugin up to date if y'all ever want to add it back...
cbaines/leaflet-indoor#13

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Local doc site point to local esri-leaflet.js
4 participants