Cknieling/msi installer #197
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chr11115
force-pushed
the
cknieling/msi_installer
branch
from
af6f19e to
a41f235
Compare
mistafunk
requested changes
Nov 16, 2022
There was a problem hiding this comment.
Solid work! We need to revisit the installation location, I don't think automated installation into a user $HOME/houdiniX.Y is the right way.
Please study https://www.sidefx.com/docs/houdini/ref/plugins.html how we can expand our package.json to install the files at a system wide location. The only unknown to me is currently where to put package.json so that Houdini finds it automatically without us having to fiddle with Houdini environment variables.
| INSTALLER_HOUDINI_VERS.each { mv -> | ||
| unstash(name: "houdini${mv.replaceAll('\\.', '_')}") | ||
| def zipFile = cepl.findOneFile("*hdn${mv.replaceAll('\\.', '-')}*.zip") | ||
| final String zipFileName = zipFile.name |
There was a problem hiding this comment.
Should check if the zipFile has been found or explict error with a message otherwise
There was a problem hiding this comment.
The call to findOneFile already throws an error if the file isn't found
Also avoid registry checking palladio versions, since we install for multiple patch/micro versions
Updated min cmake version
chr11115
force-pushed
the
cknieling/msi_installer
branch
from
45943d4 to
c02026a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Component Guid Generation Seed is a guid that must be used when a Component with the generate guid directive ("*") is not rooted in a standard Windows Installer directory (for example, ProgramFilesFolder or CommonFilesFolder). It is recommended that this attribute be avoided and that developers install their Components under standard directories with unique names instead (for example, "ProgramFilesFolder\Company Name Product Name Version"). It is important to note that once a directory is assigned a Component Guid Generation Seed the value must not change until (and must be changed when) the path to that directory, including itself and all parent directories, changes.