Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sshImporters.ts to parse Include directive #10105

Merged
merged 2 commits into from
Jan 1, 2025

Conversation

xhiroga
Copy link
Contributor

@xhiroga xhiroga commented Dec 23, 2024

Resolve #10099

I've tested these changes locally and so far they work. However, I'm not entirely sure if this is the best approach, so I'd really appreciate any guidance or suggestions. I'm totally open to revising the code based on your feedback. Thanks in advance!

Test cases

Normal cases

  • Using wildcards in Include directives
  • Using absolute paths in Include directives
  • Using relative paths in Include directives
  • Handle specifying the same file multiple times in an Include directive
  • Handle Includes written within a Match or Host block

Error handling

  • Cyclic references in Include directives can continue to be processed.
  • Processing can continue even if the file specified in the Include directive does not have permissions.
  • Processes can continue even if the file specified by an Include directive does not exist.
  • Processes can continue even if the file specified in an Include directive has an invalid format.

@Eugeny
Copy link
Owner

Eugeny commented Dec 25, 2024

Tested it and it's looking good, thank you!

@xhiroga xhiroga mentioned this pull request Dec 29, 2024
@xhiroga xhiroga marked this pull request as ready for review December 29, 2024 10:14
@xhiroga
Copy link
Contributor Author

xhiroga commented Dec 29, 2024

@Eugeny Thanks for verifying it works so far! I’d love to hear your thoughts or suggestions whenever you can. Thank you!

@Eugeny
Copy link
Owner

Eugeny commented Jan 1, 2025

LGTM 🚀

@Eugeny Eugeny merged commit 39e3ba3 into Eugeny:master Jan 1, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.ssh/config folder problem
2 participants