Improve styleability of es-layout-link and es-layout-button.
#420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
George-Payne
added
the
@eventstore-ui/layout
Changed: - Use `focus-visible` rather than `focus`. Added parts: - `counter` - The counter element, if rendered. - `badge` - The badge element, if rendered. - `icon` - The icon element, if rendered. Added css variables: - `--icon-gap` - The space between the icon and the text - `--icon-size` - The size of the icon. - `--vertical-spacing` - The total space between one button and another. - `--highlight-color` - The text color when the button is focused or hovered. - `--highlight-background-color` - The background color when the button is focused or hovered. - `--highlight-decoration` - The text decoration when the button is focused or hovered.
teamchong
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed:
focus-visiblerather thanfocus.Added parts:
counter- The counter element, if rendered.badge- The badge element, if rendered.icon- The icon element, if rendered.Added css variables:
--icon-gap- The space between the icon and the text--icon-size- The size of the icon.--vertical-spacing- The total space between one button and another.--highlight-color- The text color when the button is focused or hovered.--highlight-background-color- The background color when the button is focused or hovered.--highlight-decoration- The text decoration when the button is focused or hovered.