Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: daft documentation v2 #3595

Merged
merged 12 commits into from
Dec 19, 2024
Merged

docs: daft documentation v2 #3595

merged 12 commits into from
Dec 19, 2024

Conversation

ccmao1130
Copy link
Contributor

@ccmao1130 ccmao1130 commented Dec 18, 2024

Moved to-do's here: #3621

@github-actions github-actions bot added the docs label Dec 18, 2024
Copy link

codspeed-hq bot commented Dec 18, 2024

CodSpeed Performance Report

Merging #3595 will improve performances by 40.56%

Comparing daft-docs-v2 (c31f7fe) with main (063de4d)

Summary

⚡ 1 improvements
✅ 26 untouched benchmarks

Benchmarks breakdown

Benchmark main daft-docs-v2 Change
test_iter_rows_first_row[100 Small Files] 304.4 ms 216.6 ms +40.56%

@ccmao1130 ccmao1130 self-assigned this Dec 19, 2024
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.80%. Comparing base (ca4d3f7) to head (c31f7fe).
Report is 9 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3595   +/-   ##
=======================================
  Coverage   77.80%   77.80%           
=======================================
  Files         718      718           
  Lines       88176    88250   +74     
=======================================
+ Hits        68607    68667   +60     
- Misses      19569    19583   +14     

see 18 files with indirect coverage changes

@ccmao1130
Copy link
Contributor Author

ccmao1130 commented Dec 19, 2024

Build keeps failing on

check yaml...............................................................Failed
- hook id: check-yaml
- exit code: 1

could not determine a constructor for the tag 'tag:yaml.org,2002:python/name:material.extensions.emoji.twemoji'
  in "mkdocs.yml", line 131, column 18

Trying to figure out why (related issue here and here)... worst case we can just remove all the icons...

@samster25
Copy link
Member

Build keeps failing on

check yaml...............................................................Failed
- hook id: check-yaml
- exit code: 1

could not determine a constructor for the tag 'tag:yaml.org,2002:python/name:material.extensions.emoji.twemoji'
  in "mkdocs.yml", line 131, column 18

Trying to figure out why (related issue here and here)... worst case we can just remove all the icons...

Pushed a commit to allow unsafe yaml, should be good now

@samster25
Copy link
Member

will merge after we cut 0.4

@samster25 samster25 enabled auto-merge (squash) December 19, 2024 08:36
@samster25 samster25 merged commit fb66ed1 into main Dec 19, 2024
41 checks passed
@samster25 samster25 deleted the daft-docs-v2 branch December 19, 2024 08:44
@ccmao1130 ccmao1130 mentioned this pull request Dec 19, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants