Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu list on mobile devices clicking weird animation #58

Closed
NirajD10 opened this issue Apr 30, 2023 · 9 comments · Fixed by #91
Closed

Menu list on mobile devices clicking weird animation #58

NirajD10 opened this issue Apr 30, 2023 · 9 comments · Fixed by #91
Assignees
Labels
bug Something isn't working frontend good first issue Good for newcomers

Comments

@NirajD10
Copy link
Contributor

Describe the bug
when we are responsive mode(mobile view), by clicking dark or white mode button they change position of list.

Expected behavior
disable animation(only mobile view) and add background color when we click one of menu items.

Screenshots

animation.disable.in.mobile.view.mp4

Smartphone (please complete the following information):

  • Device: All
  • OS: All
  • Browser All
@NirajD10 NirajD10 changed the title Menu list on menu clicking weird animation Menu list on mobile devices clicking weird animation Apr 30, 2023
@FlavioAdamo
Copy link
Member

@NirajD10 @gdjohn4s
Something like this?
navbar

@gdjohn4s
Copy link
Member

@FlavioAdamo oh i like this hover effect 🙂. But i dont think it will solve the mobile issue btw

@gdjohn4s gdjohn4s added bug Something isn't working good first issue Good for newcomers frontend labels May 1, 2023
@NirajD10
Copy link
Contributor Author

NirajD10 commented May 1, 2023

@FlavioAdamo Yeah but in mobile view we can add active pseudo classes instead of hover. and disable scale animation

@iamjamesfrancis
Copy link
Contributor

iamjamesfrancis commented May 2, 2023

Hi @NirajD10,
Please review the video below and confirm if that is what you want.

APIVault.mp4

@NirajD10
Copy link
Contributor Author

NirajD10 commented May 3, 2023

@iamjamesfrancis nice one. one more thing, does it work when you click one of list categories?

by the way you can do it PR, the moderator will check code.

@FlavioAdamo
Copy link
Member

FlavioAdamo commented May 3, 2023

@iamjamesfrancis Good job!
A few things to make it even look better:

  • Add a border radius to the hover effect
  • save the background hover color variable in the style.css

When you are ready we will review the PR

@iamjamesfrancis
Copy link
Contributor

Hi all,
Thank you for your feedback.

@NirajD10, I added the same styling for categories as well.

@FlavioAdamo, Sure with those requirements I will create the PR before 22:00 IST. 😊

@FlavioAdamo
Copy link
Member

@iamjamesfrancis Thanks you! Take your time, even if it takes you a couple of day don't worry!

@gdjohn4s
Copy link
Member

gdjohn4s commented May 3, 2023

Yeah and thank you so much 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants