Fixed animations on menu list items #91
Merged
+50
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdjohn4s
approved these changes
May 3, 2023
There was a problem hiding this comment.
I like it so much.
We'll wait for @FlavioAdamo Review as well.
Thank you!
|
Also, I accidentally fixed a UI issue while doing this issue. Before UI-issue.mp4Now UI-issue-fixed.mp4 |
|
Pull request accepted! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do?
Fixes #58
Changes
.sidebar-text-wrapperfrom the anchor tag of sidebar list items because it is creating a weird hover..mx-2from the<font-awesome-icon>tags and replaced the spacing using.gap-2.nav-linkfrom the<a>infrontend/src/components/Navbar.vuebecause itsdisplay: blockis affecting the propertydisplay: flex..flexand.items-centerinfrontend/src/style.css.Screenshots
Mobile View
mobile-view.mp4
Desktop View
desktop-view.mp4