Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I updated to theme button to a toggle #170

Merged
merged 4 commits into from
May 17, 2023
Merged

Conversation

cyberGHostJs
Copy link
Contributor

@cyberGHostJs cyberGHostJs commented May 17, 2023

Description

This PR contains theme toggle feature.

Related Issues

#166

Checklist

  • My submission is formatted according to the guidelines in the contributing guide
  • My addition is ordered alphabetically
  • My submission has a useful description
  • Code follows the established CODE_OF_CONDUCT guidelines.
  • Code has been tested thoroughly and passes all tests.
  • All commit messages are descriptive and follow the established commit message format.
  • Pull request title follows the established pull request title format.
  • Pull request description clearly describes the changes included in the pull request.
  • The description does not have more than 100 characters
  • I have searched the repository for any relevant issues or pull requests

@cyberGHostJs
Copy link
Contributor Author

Screen Shot 2023-05-17 at 9 58 40 AM
Screen Shot 2023-05-17 at 9 58 26 AM

Copy link
Member

@gdjohn4s gdjohn4s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for your contribution.
you need to make just a few modifications:

  • on ToggleButton.vue can you use the composition api? (<script setup>)
  • can you format the document again using this extension? your document formatting is not compliant with apivault code
image Can you also provide more informations about this PR? i've edited the PR with correct template

@gdjohn4s gdjohn4s added enhancement New feature or request frontend labels May 17, 2023
@cyberGHostJs
Copy link
Contributor Author

okay, will do that shortly.

cyberGHostJs and others added 2 commits May 17, 2023 11:54
the font awesome icons are unnecessary here because those are already imported in **main.js** file
Copy link
Member

@gdjohn4s gdjohn4s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved.
just made a little modification on ToggleButton.vue:

  • removed font awesome unnecessary imports (those are already imported in main.js file)

little note:
next time fill up the PR template 😄
thank you! ❤️

@cyberGHostJs
Copy link
Contributor Author

cyberGHostJs commented May 17, 2023 via email

@gdjohn4s gdjohn4s merged commit 480859a into Exifly:main May 17, 2023
@gdjohn4s
Copy link
Member

@cyberGHostJs no problems! 😄 we had merged this PR already
thank you again!

@gdjohn4s gdjohn4s mentioned this pull request May 23, 2023
12 tasks
@gdjohn4s gdjohn4s mentioned this pull request Jun 1, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants