-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I updated to theme button to a toggle #170
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for your contribution.
you need to make just a few modifications:
- on ToggleButton.vue can you use the composition api? (<script setup>)
- can you format the document again using this extension? your document formatting is not compliant with apivault code
okay, will do that shortly. |
the font awesome icons are unnecessary here because those are already imported in **main.js** file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved.
just made a little modification on ToggleButton.vue:
- removed font awesome unnecessary imports (those are already imported in main.js file)
little note:
next time fill up the PR template 😄
thank you! ❤️
Hello John, I got the notification of your correction. Thanks a lot I’ll
look through the code and take correction. I actually have been working on
the correction all day with no break through 😅. Thank you once again
|
@cyberGHostJs no problems! 😄 we had merged this PR already |
Description
This PR contains theme toggle feature.
Related Issues
#166
Checklist