Colorscheme refactoring and fixes #179
Merged
+90
−102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdjohn4s
added
documentation
FlavioAdamo
requested changes
May 25, 2023
frontend/components/Navbar.vue
Outdated
| setThemeElements(theme); | ||
| theme.value = setTheme(); | ||
| const isDarkTheme: boolean = | ||
| theme.value === "dark" || theme.value === null ? true : false; |
There was a problem hiding this comment.
- theme.value === "dark" || theme.value === null ? true : false;
+ theme.value === "dark" || theme.value === null
frontend/utils/themeutils.ts
Outdated
Comment on lines
21
to
26
| export const getThemeElements = (theme: globalThis.Ref<string>): boolean => { | ||
| if (theme.value === null || theme.value === 'dark') { | ||
| return true | ||
| } | ||
| document.querySelector("body")?.setAttribute("data-theme", theme.value); | ||
| return false; | ||
| } |
There was a problem hiding this comment.
Can be replaced with
+ return theme.value === null || theme.value === 'dark'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As stated in the title, this PR aims to improve the code regarding the color scheme.
Proposed Changes
In detail:
The reason for these changes is code optimization.
Checklist