Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/firebase #199

Merged
merged 3 commits into from
Jun 3, 2023
Merged

fix/firebase #199

merged 3 commits into from
Jun 3, 2023
+32 −0

Conversation

gdjohn4s
Copy link
Member

@gdjohn4s gdjohn4s commented Jun 3, 2023

  • feat/added firebase config type
  • fix/defined firebase plugin

Description

On nuxt 3 firebase instance needs to be defined as a nuxt plugin.
This PR provide the correct configuration to let firebase works correctly.

Checklist

  • My submission is formatted according to the guidelines in the contributing guide
  • My addition is ordered alphabetically
  • My submission has a useful description
  • Code follows the established CODE_OF_CONDUCT guidelines.
  • Code has been tested thoroughly and passes all tests.
  • All commit messages are descriptive and follow the established commit message format.
  • Pull request title follows the established pull request title format.
  • Pull request description clearly describes the changes included in the pull request.
  • The description does not have more than 100 characters
  • Each table column is padded with one space on either side
  • I have searched the repository for any relevant issues or pull requests
  • Any category I am creating has the minimum requirement of 3 items

@gdjohn4s gdjohn4s added bug Something isn't working frontend labels Jun 3, 2023
@gdjohn4s gdjohn4s requested a review from FlavioAdamo June 3, 2023 12:57
@FlavioAdamo FlavioAdamo merged commit 13f8714 into main Jun 3, 2023
@FlavioAdamo FlavioAdamo deleted the fix/firebase branch June 3, 2023 13:02
This was referenced Jun 3, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlavioAdamo FlavioAdamo FlavioAdamo approved these changes

Assignees
No one assigned
Labels
bug Something isn't working frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gdjohn4s @FlavioAdamo