Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment][OldDot Rules Migration] Add "Rules" Row/toggle to "More Features" page #46935

Closed
marcaaron opened this issue Aug 7, 2024 · 14 comments
Assignees
Labels
Daily KSv2 Engineering NewFeature Something to build that is a new item. Reviewing Has a PR in review

Comments

@marcaaron
Copy link
Contributor

marcaaron commented Aug 7, 2024

Part of the OldDot Rules Migration project

Main issue: https://github.com/Expensify/Expensify/issues/413886

Feature Description

2024-08-07_13-46-09

2024-08-07_14-30-45

High Level Section: https://docs.google.com/document/d/1oLr14YhL6Y0N5g4tbozdIIrFbybBlsRA0H9I8Wm--w8/edit#bookmark=id.uy912otsdb3a

Detailed Section: https://docs.google.com/document/d/1oLr14YhL6Y0N5g4tbozdIIrFbybBlsRA0H9I8Wm--w8/edit#bookmark=id.dlbimjgr7u70

Manual Test Steps

TBD

Automated Tests

TBD

@marcaaron marcaaron self-assigned this Aug 7, 2024
@marcaaron marcaaron changed the title [Rules Migration] Front End: Toggling on Rules -> Individual Expense Rules sections [OldDot Rules Migration] Front End: Toggling on Rules -> Individual Expense Rules sections Aug 7, 2024
@marcaaron marcaaron changed the title [OldDot Rules Migration] Front End: Toggling on Rules -> Individual Expense Rules sections [OldDot Rules Migration] Front End: Add "Rules" Row/toggle to "More Features" page Aug 7, 2024
@marcaaron marcaaron changed the title [OldDot Rules Migration] Front End: Add "Rules" Row/toggle to "More Features" page [OldDot Rules Migration] Add "Rules" Row/toggle to "More Features" page Aug 7, 2024
@melvin-bot melvin-bot bot added Monthly KSv2 Reviewing Has a PR in review Weekly KSv2 and removed Monthly KSv2 labels Aug 12, 2024
@marcaaron marcaaron added Daily KSv2 and removed Weekly KSv2 labels Aug 15, 2024
@marcaaron
Copy link
Contributor Author

This is in progress now. @WojtekBoman kicked us off. I asked for some translations to be reviewed here.

Copy link

melvin-bot bot commented Aug 22, 2024

@marcaaron Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@marcaaron
Copy link
Contributor Author

The beta code has been moved to production so we should be able to move forward on the held PRs 🚀

Copy link

melvin-bot bot commented Aug 30, 2024

@marcaaron Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Copy link

melvin-bot bot commented Sep 3, 2024

@marcaaron Still overdue 6 days?! Let's take care of this!

@mkhutornyi
Copy link
Contributor

C+ payment is remaining

Copy link

melvin-bot bot commented Sep 5, 2024

@marcaaron 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

Copy link

melvin-bot bot commented Sep 9, 2024

@marcaaron 12 days overdue now... This issue's end is nigh!

@marcaaron marcaaron added the NewFeature Something to build that is a new item. label Sep 9, 2024
Copy link

melvin-bot bot commented Sep 9, 2024

Triggered auto assignment to @johncschuster (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Sep 9, 2024
@marcaaron
Copy link
Contributor Author

Hey @johncschuster would you kindly help @mkhutornyi get paid for their work as the C+ reviewing the linked PR? It's a new feature and nobody else needs to be paid.

Copy link

melvin-bot bot commented Sep 10, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@johncschuster
Copy link
Contributor

Ah! Sorry I missed this, @marcaaron! I review my HOLD for payment issues every day, but it looks like I missed this without the automatic change. I'll get payment issued today!

@johncschuster johncschuster changed the title [OldDot Rules Migration] Add "Rules" Row/toggle to "More Features" page [HOLD for payment][OldDot Rules Migration] Add "Rules" Row/toggle to "More Features" page Sep 10, 2024
@johncschuster
Copy link
Contributor

@mkhutornyi I've just sent you an offer through Upwork. Can you please accept that?

@johncschuster johncschuster added Daily KSv2 and removed Weekly KSv2 labels Sep 11, 2024
@johncschuster
Copy link
Contributor

This has been paid. Thanks, everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering NewFeature Something to build that is a new item. Reviewing Has a PR in review
Projects
Status: Done
Development

No branches or pull requests

3 participants