iOS Rules - Text cursor moves to front after entering the third digit in Percentage field

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.31-5
Reproducible in staging?: Y
Reproducible in production?: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

1. Launch New Expensify app.
2. Go to Workspace settings > Rules.
3. Enable Auto-approve compliant reports
4. Tap Random report audit.
5. Try enter three digits in the input field.

Expected Result:

The text cursor will not move to the front after entering the third digit.

Actual Result:

The text cursor moves to the front after entering the third digit.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6598271_1725941135319.ScreenRecording_09-10-2024_12-02-09_1.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @iwiznia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[iwiznia]

Since this is only happening in one platform and when you try to enter 3 numbers (which is not really valid), going to remove the blocker.

I think this was added in #47083 which is part of #46935 so maybe @WojtekBoman you want to take a look?

[huult]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Text cursor moves to front after entering the third digit in Percentage field

What is the root cause of that problem?

this issue seems to stem from React Native’s handling of inputs on mobile, http://facebook/react-native#36494

What changes do you think we should make in order to solve the problem?

We can use a workaround (maxLength) to prevent this.

// src/components/PercentageForm.tsx#L71

+    const getMaxLength = useCallback(() => {
+        const numValue = parseInt(currentAmount || "0", 10);
    
+        if ((numValue >= 0 && numValue <= 9) || (numValue >= 11 && numValue <= 99)) {
+           return 2;
+        }
    
+        return 3;
+    }, [currentAmount]);

// src/components/PercentageForm.tsx#L73
      <TextInput
            ...
+         maxLength={getMaxLength()}

POC

Screen.Recording.2024-09-10.at.23.30.44.mp4

[iwiznia]

@WojtekBoman bump on #48869 (comment)

[WojtekBoman]

Sure I'll take a look, sorry for the delay, I didn't notice the message

[miljakljajic]

Heading out on my parental leave - it seems like this is being handled by @WojtekBoman from software mansion so I will not re-assign another BZ team member. Please add someone else on if I am wrong.

[melvin-bot]

This issue has not been updated in over 15 days. @iwiznia, @WojtekBoman eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[Christinadobrzyn]

Hi @WojtekBoman can you tell me if this the fix you're working on might also fix the report here - #50886

[WojtekBoman]

This issue should be closed, the PR fixing it has already been merged
cc: @iwiznia