[HOLD for payment 2025-01-13] [$250] After paying expense and canceling payment don't scroll down to comments

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.66-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @dukenv0307
Slack conversation (hyperlinked to channel name): ts_external_expensify_bugs

Action Performed:

1. Submit expense > Complete the flow
2. Pay the request
3. Go to transaction thread > Click on header > Cancel payment

Expected Result:

After paying expense and canceling payment scroll down to the comments

Actual Result:

After paying expense and canceling payment don't scroll down to the comments

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

bug.mp4

Recording.794.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021861289275630369185
• Upwork Job ID: 1861289275630369185
• Last Price Increase: 2024-11-26
• Automatic offers:
• nkdengineer | Contributor | 105164617

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @kadiealexander

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[mkzie2]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After paying expense and canceling payment don't scroll down to the comments

What is the root cause of that problem?

We do not call notifyNewAction after cancelling payment.

What changes do you think we should make in order to solve the problem?

Add Report.notifyNewAction to IOU.cancelPayment

App/src/libs/actions/IOU.ts

Line 7309 in e08c53a

function cancelPayment(expenseReport: OnyxEntry<OnyxTypes.Report>, chatReport: OnyxTypes.Report) {

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After paying expense and canceling payment don't scroll down

What is the root cause of that problem?

We are missing Report.notifyNewAction to scroll to the bottom when we call PayMoneyRequest API and CancelPayment API

App/src/libs/actions/IOU.ts

Line 7464 in 51e25af

API.write(apiCommand, params, {optimisticData, successData, failureData});

App/src/libs/actions/IOU.ts

Lines 7397 to 7406 in 51e25af

	API.write(
	WRITE_COMMANDS.CANCEL_PAYMENT,
	{
	iouReportID: expenseReport.reportID,
	chatReportID: chatReport.reportID,
	managerAccountID: expenseReport.managerID ?? -1,
	reportActionID: optimisticReportAction.reportActionID,
	},
	{optimisticData, successData, failureData},
	);

What changes do you think we should make in order to solve the problem?

We should add notifyNewAction to scroll to the bottom here, here after calling API like we did with other actions

    Report.notifyNewAction(iouReport?.reportID ?? '', userAccountID);

    Report.notifyNewAction(expenseReport.reportID, userAccountID);

What alternative solutions did you explore? (Optional)

[dukenv0307]

I can help take this issue as C+ since I have the context on it @kadiealexander

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021861289275630369185

[melvin-bot]

Current assignee @dukenv0307 is eligible for the External assigner, not assigning anyone new.

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After paying expense and canceling payment don't scroll down to comments

What is the root cause of that problem?

We already have a code that will scroll to bottom whenever the last action is changed on the report here

App/src/pages/home/report/ReportActionsList.tsx

Lines 374 to 379 in 084a711

	scrollingVerticalOffset.current < AUTOSCROLL_TO_TOP_THRESHOLD &&
	previousLastIndex.current !== lastActionIndex &&
	reportActionSize.current > sortedVisibleReportActions.length &&
	hasNewestReportAction
	) {
	reportScrollManager.scrollToBottom();

but in our case hasNewesReportAction will be false

App/src/pages/home/report/ReportActionsList.tsx

Line 362 in 084a711

const hasNewestReportAction = lastAction?.created === lastVisibleActionCreated;

hasNewesReportAction will ensure that the last action does exist in our report action list but in our case although we added the payed and cancelled payment report actions optimistically we forgot to update lastVisibleActionCreated with the last action created timestamp

App/src/libs/actions/IOU.ts

Lines 6615 to 6625 in 084a711

	[optimisticIOUReportAction.reportActionID]: {
	...(optimisticIOUReportAction as OnyxTypes.ReportAction),
	pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD,
	},
	},
	},
	{
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.REPORT}${iouReport?.reportID ?? ''}`,
	value: {
	...iouReport,

App/src/libs/actions/IOU.ts

Lines 7385 to 7395 in 084a711

	...(optimisticReportAction as OnyxTypes.ReportAction),
	pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD,
	},
	},
	},
	{
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.REPORT}${expenseReport.reportID}`,
	value: {
	...expenseReport,
	lastMessageText: ReportActionsUtils.getReportActionText(optimisticReportAction),

What changes do you think we should make in order to solve the problem?

We will need to set the lastVisibleActionCreated field correctly

App/src/libs/actions/IOU.ts

Line 7394 in 084a711

...expenseReport,

               lastVisibleActionCreated: optimisticReportAction.created,

App/src/libs/actions/IOU.ts

Line 6625 in 084a711

...iouReport,

                lastVisibleActionCreated: optimisticIOUReportAction.created,

and for cancel payment we need to revert previous value on failureData here

App/src/libs/actions/IOU.ts

Line 7435 in 084a711

statusNum: CONST.REPORT.STATUS_NUM.REIMBURSED,

                lastVisibleActionCreated: expenseReport.lastVisibleActionCreated,

but for pay we are already doing it here

App/src/libs/actions/IOU.ts

Lines 6673 to 6675 in 084a711

	key: `${ONYXKEYS.COLLECTION.REPORT}${iouReport?.reportID ?? ''}`,
	value: {
	...iouReport,

POC:

2024-11-26.17-14-42.mp4

What alternative solutions did you explore? (Optional)

[kadiealexander]

@dukenv0307 bump!

[dukenv0307]

I'm reviewing.

[dukenv0307]

Thanks for all your proposals

@mkzie2 Your solution doesn't fix pay expense case

@FitseTLT Your solution is not correct to me

Here's the PR to do that: 1d4aef1

And it's purpose is to handle deleting message. I also applied your solution and it didn't work

web-resize.mp4

@nkdengineer's proposal looks good to me, we used the same approaches in many places.

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @jasperhuangg, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @nkdengineer 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

This issue has not been updated in over 15 days. @jasperhuangg, @kadiealexander, @dukenv0307, @nkdengineer eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.80-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: paying expense and canceling payment don't scroll down to comments #53430

If no regressions arise, payment will be issued on 2025-01-13. 🎊

For reference, here are some details about the assignees on this issue:

• @dukenv0307 requires payment through NewDot Manual Requests
• @nkdengineer requires payment automatic offer (Contributor)

[melvin-bot]

@dukenv0307 @kadiealexander @dukenv0307 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[dukenv0307]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production
• 2b. Reported on staging (deploy blocker)
• 2c. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: https://github.com/Expensify/App/pull/40168/files#r1904878924

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: N/A

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. Yes

Regression Test Proposal Template

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue: https://github.com/Expensify/Expensify/issues/460541

Regression Test Proposal

Test:

1. Submit expense > Complete the flow
2. Pay the request
3. Go to transaction thread > Click on header > Cancel payment
4. Verify that: After paying expense and canceling payment scroll down to the comments

Do we agree 👍 or 👎

[kadiealexander]

Payments due:

• Contributor: @nkdengineer paid $250 via Upwork automatic offer
• Reviewer: @dukenv0307 owed $250 via NewDot Manual Requests