[HOLD for payment 2025-01-15] Android - Chat - Emoji picker is jumpy when opened from context menu

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.77-6
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team
Component: Chat Report View

Action Performed:

1. Launch ND or hybrid app
2. Open DM
3. Send a message to the DM if there is no message
4. Tap on the composer if keyboard is not up
5. Long tap on the message while keyboard is up
6. Tap Add reaction button
7. Might need to repeat Step 4 to 6 if the emoji picker is not jumpy

Expected Result:

Emoji picker will not be jumpy when opened from context menu when keyboard is opened

Actual Result:

Emoji picker is jumpy when opened from context menu when keyboard is opened

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6700988_1734891250375.Screen_Recording_20241223_021231_Expensify.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @mallenexpensify

[melvin-bot]

Triggered auto assignment to @arosiclair (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[lanitochka17]

Production:

Uploading Screenrecorder-2024-12-22-20-33-16-287.mp4…

[techievivek]

Doesn't seem to be a backend bug so removing the Deployblocker label from it.

[arosiclair]

Attempting to reproduce this in dev. I'll see if reverting a couple PRs fixes the issue.

[arosiclair]

Reverting #54187 seems to fix it but I'm not 100% sure. @kirillzyusko can you take a look at this?

In the meantime I'm going to demote this since it's minor.

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[kirillzyusko]

@arosiclair yes, sure, feel free to assign me on this issue 👀 Will be happy to help here!

[kirillzyusko]

@arosiclair it's not a deploy blocker, right?

The thing is why EmojiPicker is jumpy is because we instantly change padding. And it always was looking weird. I believe with the help of keyboard-controller I can achieve smooth animations and re-work the code.

just want to understand whether it's a DeployBlocker or not (whether do we need to revert a PR and prepare a new PR that will fix prev and that issue) 🤔

[arosiclair]

@arosiclair it's not a deploy blocker, right?

No it's not. I think it's relatively minor so I demoted this issue.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.81-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: smooth keyboard handling in BaseModal #54533

If no regressions arise, payment will be issued on 2025-01-15. 🎊

For reference, here are some details about the assignees on this issue:

• @kirillzyusko does not require payment (Contractor)

[melvin-bot]

@arosiclair @mallenexpensify @kirillzyusko The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[arosiclair]

@parasharrajat was the C+ for this

[melvin-bot]

Payment Summary

Upwork Job

• Contributor: @kirillzyusko is from an agency-contributor and not due payment
• Reviewer: @parasharrajat owed $250 via NewDot

BugZero Checklist (@mallenexpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[parasharrajat]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: Not needed as it is a improvement over existing code.

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: NA

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue: https://github.com/Expensify/Expensify/issues/462308

Regression Test Proposal

Test:

1. Launch ND or hybrid app
2. Open DM
3. Send a message to the DM if there is no message
4. Tap on the composer if keyboard is not up
5. Long tap on the message while keyboard is up
6. Tap Add reaction button
7. repeat Step 4 to 6 and be sure the emoji picker is not jumpy
8. tap on Search field and make sure bottom sheet has an animated transition (for keyboard avoidance)

Do we agree 👍 or 👎

[melvin-bot]

@arosiclair, @mallenexpensify, @kirillzyusko, @parasharrajat Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[kirillzyusko]

@danstepanov is working on this to fix 👀

[parasharrajat]

This one is fixed. @kirillzyusko That is a different issue

[mallenexpensify]

Contributor+: @parasharrajat due $250 via NewDot

Test Case

• https://github.com/Expensify/Expensify/issues/462308

[parasharrajat]

Payment requested as per #54453 (comment)

[JmillsExpensify]

$250 approved for @parasharrajat