Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP Staging] Revert "[Composer] Add logs in Composer-related logic to track bug with disappearing text" #44251

Merged
merged 1 commit into from
Jun 24, 2024
Merged

[CP Staging] Revert "[Composer] Add logs in Composer-related logic to track bug with disappearing text" #44251

merged 1 commit into from
Jun 24, 2024

Conversation

muttmuure
Copy link
Contributor

@muttmuure muttmuure requested a review from a team June 24, 2024 12:27
@muttmuure muttmuure self-assigned this Jun 24, 2024
@melvin-bot melvin-bot bot removed the request for review from a team June 24, 2024 12:28
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Jun 24, 2024

@srikarparsi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot requested a review from srikarparsi June 24, 2024 12:28
mountiny
mountiny approved these changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@mountiny mountiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straight revert

@mountiny mountiny changed the title Revert "[Composer] Add logs in Composer-related logic to track bug with disappearing text" [CP Staging] Revert "[Composer] Add logs in Composer-related logic to track bug with disappearing text" Jun 24, 2024
@mountiny mountiny merged commit 200590d into main Jun 24, 2024
12 of 15 checks passed
@mountiny mountiny deleted the revert-44106-add-logs-to-composer branch June 24, 2024 12:30
@melvin-bot melvin-bot bot added the Emergency label Jun 24, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Jun 24, 2024

@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@mountiny
Copy link
Contributor

Straight revert

OSBotify pushed a commit that referenced this pull request Jun 24, 2024
@mountiny @OSBotify
Merge pull request #44251 from Expensify/revert-44106-add-logs-to-com…
a15b53b 
…poser

[CP Staging] Revert "[Composer] Add logs in Composer-related logic to track bug with disappearing text"

(cherry picked from commit 200590d)
@github-actions github-actions bot mentioned this pull request Jun 24, 2024
Closed
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.0.1-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 success ✅
🕸 web 🕸 failure ❌

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@Julesssss
Copy link
Contributor

@muttmuure @mountiny ignore the above failure, as of 9.0.1-6 this is resolved on all platforms.

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.1-19 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mountiny mountiny mountiny approved these changes

@srikarparsi srikarparsi Awaiting requested review from srikarparsi

Assignees

@muttmuure muttmuure

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@muttmuure @mountiny @OSBotify @Julesssss