Upgrade to React Native 0.76 #51475

j-piasecki · 2024-10-25T14:54:13Z

Details

This PR upgrades the version of React Native used in the App to 0.76.

Upstream PRs:

Select text inside TextInput only once from onLayout facebook/react-native#47902
Transaction merging can cause CREATE mutations to be effectively dropped facebook/react-native#47960
Fix "folly::toJson: JSON object value was an INF" software-mansion/react-native-reanimated#6773
Use nullish assignment operator to assign entries in FormData expo/expo#33445
Export types using export type instead of export in expo-image-manipulator expo/expo#33446
Import types using import-type instead of import in expo-modules-core expo/expo#33447

Notes:

https://github.com/react-native-modal/react-native-modal - seems not to be maintained anymore
https://github.com/margelo/react-native-quick-sqlite - deprecated in favor of react-native-nitro-sqlite

Fixed Issues

$ #48911
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

github-actions · 2025-01-07T13:37:09Z

🚧 @mountiny has triggered a test build. You can view the workflow run here.

github-actions · 2025-01-07T14:05:27Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/51475/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/51475/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/51475/NewExpensify.dmg	https://51475.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

jayeshmangwani · 2025-01-07T14:28:58Z

@WoLewicki I'm encountering this console error when switching chats. This warning doesn't appear on staging, so it might be related to our PR (Please ignore this for now. I'm not seeing this issue when running the web app locally; it's only appearing as a warning in the workflow build).

WoLewicki · 2025-01-07T15:02:28Z

Did you check on the newest build @jayeshmangwani ? I am switching chats there and I don't see that error.

jayeshmangwani · 2025-01-07T15:36:27Z

Did you check on the newest build

I tested it with the latest version in incognito mode, and it's not happening now

jayeshmangwani · 2025-01-07T15:39:25Z

@WoLewicki I noticed some differences in the pod lock file locally. Could you confirm if you forgot to push those changes, or if it's just a local difference on my end that we can ignore?

jayeshmangwani · 2025-01-07T15:41:10Z

If possible, could we also fix the (rulesdir/no-default-id-values ) lint failure in the OptionRowLHN.tsx file here?

jayeshmangwani · 2025-01-07T15:41:56Z

@WoLewicki @mountiny I’ve tested on web, desktop, iOS (locally), and Android. So far, I haven’t found anything unusual during testing; everything seems perfectly fine to me.

WoLewicki · 2025-01-07T15:52:19Z

If possible, could we also fix the (rulesdir/no-default-id-values ) lint failure in the OptionRowLHN.tsx file here?

We talked about it already and since those changes are not coming from this PR, I would restrain from doing it.

I noticed some differences in the pod lock file locally. Could you confirm if you forgot to push those changes, or if it's just a local difference on my end that we can ignore?

I retested running pod install and did not get any changes. Also, the job checking the Podfile.lock succeded on CI so I think it might be something on your end.

jayeshmangwani · 2025-01-07T16:07:59Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

jayeshmangwani

lgtm 🚀

mountiny

Thanks for the hard work. Lots of testing was done, QA did full regression testing and C+ did a thorough testing through the app, but as it goes with prs like this, there will be some issues stemming from it. @WoLewicki @j-piasecki please make sure to be around tomorrow to help with any issues as we will most likely not revert this PR and we want to avoid holding deploy for a long time, thank you!

mountiny · 2025-01-07T18:53:17Z

package.json

-    "expo-image": "1.12.15",
-    "expo-image-manipulator": "12.0.5",
+    "expo": "52.0.14",
+    "expo-asset": "^11.0.1",


What do we need this one for?

mountiny · 2025-01-07T18:53:22Z

package.json

+    "expo": "52.0.14",
+    "expo-asset": "^11.0.1",
+    "expo-av": "^15.0.1",
+    "expo-font": "^13.0.1",


mountiny · 2025-01-07T18:54:57Z

patches/expo-image-manipulator+13.0.5+002+fix-type-exports.patch

@@ -0,0 +1,17 @@
+diff --git a/node_modules/expo-image-manipulator/src/index.ts b/node_modules/expo-image-manipulator/src/index.ts


Can you please make sure all the new patches added here are tracked? I see you have added them to the list in the PR, but just reminding here if its up to date?

mountiny · 2025-01-07T18:59:43Z

The ESLint check is failing because of one file but we will migrate that in another PR to avoid scope creep

melvin-bot · 2025-01-07T19:04:35Z

@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

mountiny · 2025-01-07T19:05:52Z

Not emergency as explained just above

OSBotify · 2025-01-07T19:16:23Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-01-08T02:59:35Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.82-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

github-actions · 2025-01-08T03:39:24Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.82-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

shubham1206agra · 2025-01-08T12:26:35Z

android/build.gradle

-        compileSdkVersion = 34
+        buildToolsVersion = "35.0.0"
+        minSdkVersion = 24
+        compileSdkVersion = 35
        targetSdkVersion = 34


@WoLewicki Shouldn't targetSdkVersion be 35 as well?

WoLewicki and others added 16 commits October 21, 2024 17:32

feat: update patches for expo

44682c9

feat: bump to newest RN

ffae2d9

chore: update patch numbers

e520b04

feat: update expo

d4c742b

chore: merge current main

54586a7

fix: update patches and fix gradle build

9df77bf

Bump to stable 0.76 and expo preview 3

43696bd

Add patch for mapbox

91253f2

Fix headless tasks causing crash

49d1255

Merge branch 'main' into @wolewicki/rn-76-upgrade

55aa7d3

Fix Android build

d9ed4fa

Merge branch 'main' into @wolewicki/rn-76-upgrade

9e2ef24

Fix lint

7ca13d2

Fix mock

3d5d0af

Merge branch 'main' into @wolewicki/rn-76-upgrade

99ae53e

Build Github Actions

3086b54

mountiny added the Ready To Build label Oct 28, 2024

This comment has been minimized.

Sign in to view

WoLewicki and others added 12 commits October 28, 2024 17:57

fix: enable bridgeless again

5a8cdbc

Merge branch 'main' into @wolewicki/rn-76-upgrade

e5f32d7

Override regexpu-core version

af36d31

Fix ios build

30bf3a5

Move git tests to other directory

ece3d70

Fix middleware tests

926bde4

Merge process from Expo and NodeJS

7c3f55d

Restore previous configs

7e6d265

Fix types & eslint

7dfffdd

Transpile updated expo modules on web

4358c2e

Add patches for type imports

50be77f

Merge branch 'main' into @wolewicki/rn-76-upgrade

4df9f59

brunovjk mentioned this pull request Dec 26, 2024

[HOLD React Native 0.76] [$250] iOS Workspace - Invite message field does not auto-focus #53346

Open

8 tasks

szymonrybczak mentioned this pull request Dec 27, 2024

feat(Android): setup background task #54616

Open

49 tasks

mhoran mentioned this pull request Jan 7, 2025

[HOLD for #37437][$2000] Pressing space 2 times . appears in display name #17153

Open

6 tasks

WoLewicki added 4 commits January 7, 2025 11:48

chore: merge current main

c54bea7

fix: package-lock.json

ab32749

fix: bump locks

8953c8d

Merge branch 'main' into @wolewicki/rn-76-upgrade

132c2f6

jayeshmangwani approved these changes Jan 7, 2025

View reviewed changes

mountiny approved these changes Jan 7, 2025

View reviewed changes

mountiny merged commit 476b8d5 into Expensify:main Jan 7, 2025
19 of 21 checks passed

melvin-bot bot added the Emergency label Jan 7, 2025

mountiny removed the Emergency label Jan 7, 2025

github-actions bot mentioned this pull request Jan 8, 2025

Deploy Checklist: New Expensify 2025-01-08 #54928

Open

43 tasks

shubham1206agra reviewed Jan 8, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade to React Native 0.76 #51475

Upgrade to React Native 0.76 #51475

j-piasecki commented Oct 25, 2024 •

edited

Loading

This comment has been minimized.

github-actions bot commented Jan 7, 2025

github-actions bot commented Jan 7, 2025

jayeshmangwani commented Jan 7, 2025 •

edited

Loading

WoLewicki commented Jan 7, 2025

jayeshmangwani commented Jan 7, 2025

jayeshmangwani commented Jan 7, 2025

jayeshmangwani commented Jan 7, 2025

jayeshmangwani commented Jan 7, 2025

WoLewicki commented Jan 7, 2025

jayeshmangwani commented Jan 7, 2025

jayeshmangwani left a comment

mountiny left a comment

mountiny Jan 7, 2025

mountiny Jan 7, 2025

mountiny Jan 7, 2025

mountiny commented Jan 7, 2025

melvin-bot bot commented Jan 7, 2025

mountiny commented Jan 7, 2025

OSBotify commented Jan 7, 2025

github-actions bot commented Jan 8, 2025

github-actions bot commented Jan 8, 2025

shubham1206agra Jan 8, 2025

		@@ -0,0 +1,17 @@
		diff --git a/node_modules/expo-image-manipulator/src/index.ts b/node_modules/expo-image-manipulator/src/index.ts

Upgrade to React Native 0.76 #51475

Upgrade to React Native 0.76 #51475

Conversation

j-piasecki commented Oct 25, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

This comment has been minimized.

github-actions bot commented Jan 7, 2025

github-actions bot commented Jan 7, 2025

jayeshmangwani commented Jan 7, 2025 • edited Loading

WoLewicki commented Jan 7, 2025

jayeshmangwani commented Jan 7, 2025

jayeshmangwani commented Jan 7, 2025

jayeshmangwani commented Jan 7, 2025

jayeshmangwani commented Jan 7, 2025

WoLewicki commented Jan 7, 2025

jayeshmangwani commented Jan 7, 2025

Reviewer Checklist

Screenshots/Videos

jayeshmangwani left a comment

Choose a reason for hiding this comment

mountiny left a comment

Choose a reason for hiding this comment

mountiny Jan 7, 2025

Choose a reason for hiding this comment

mountiny Jan 7, 2025

Choose a reason for hiding this comment

mountiny Jan 7, 2025

Choose a reason for hiding this comment

mountiny commented Jan 7, 2025

melvin-bot bot commented Jan 7, 2025

mountiny commented Jan 7, 2025

OSBotify commented Jan 7, 2025

github-actions bot commented Jan 8, 2025

github-actions bot commented Jan 8, 2025

shubham1206agra Jan 8, 2025

Choose a reason for hiding this comment

j-piasecki commented Oct 25, 2024 •

edited

Loading

jayeshmangwani commented Jan 7, 2025 •

edited

Loading