Fix - QAB- QAB navigates to last opened expense type rather than summited expense #53945

FitseTLT · 2024-12-11T15:04:11Z

Details

Fixed Issues

$ #53545
PROPOSAL: #53545 (comment)

Tests

Create WS
Click FAB> Submit expense> Scan receipt and submit the expense
Notice QAB displays Scan receipt option
Click FAB > Submit expense
Go to distance or manual expense option (do not submit any expense) and navigate back
Now press on FAB and quick action
Verify that the receipt page is opened

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Same as above

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

2024-12-11.18-53-23.mp4

Android: mWeb Chrome

aw.mp4

iOS: Native

i.mp4

iOS: mWeb Safari

iw.mp4

MacOS: Chrome / Safari

w.mp4

MacOS: Desktop

d.mp4

melvin-bot · 2024-12-11T15:04:17Z

@jayeshmangwani Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

jayeshmangwani · 2024-12-12T07:24:42Z

@FitseTLT Is it possible to add some automated test cases to cover the various scenarios here?

FitseTLT · 2024-12-13T15:50:22Z

@jayeshmangwani You can proceed 👍

jayeshmangwani · 2024-12-16T09:10:00Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android.mov

Android: mWeb Chrome

mweb-chrome.mov

iOS: Native

iOS.mov

iOS: mWeb Safari

mweb-safari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

src/libs/actions/QuickActionNavigation.ts

tests/unit/QuickActionNavigationTest.ts

jayeshmangwani

LGTM 🚀

jayeshmangwani · 2024-12-16T09:17:07Z

Added a few suggestions above, but that's not a bug. The PR looks good.

FitseTLT · 2024-12-16T13:18:11Z

U can proceed @MonilBhavsar

jayeshmangwani · 2024-12-16T16:39:37Z

Hey @FitseTLT, I tested the main issue on the latest version of the main, and it doesn't seem to be reproducible anymore. We've also made a few changes to the FloatingActionButtonAndPopover page in this PR today. Are we sure that removing those changes won't reintroduce the issue?

jayeshmangwani · 2024-12-16T16:40:11Z

It seems we are addressing the same issue, but with a slight difference.

FitseTLT · 2024-12-16T16:43:23Z

Hey @FitseTLT, I tested the main issue on the latest version of the main, and it doesn't seem to be reproducible anymore. We've also made a few changes to the FloatingActionButtonAndPopover page in this PR today. Are we sure that removing those changes won't reintroduce the issue?

I did see that PR and I just recently resolved the conflict. They are doing the same fix as ours although our issue is way older than theirs. But now this PR will add the missing relevant automated tests 👍

tests/unit/QuickActionNavigationTest.ts

MonilBhavsar · 2024-12-17T15:57:12Z

Also, eslint tests are failing. Please see https://expensify.slack.com/archives/C01GTK53T8Q/p1734427688036919?thread_ts=1734427537.784129&cid=C01GTK53T8Q

tests/unit/QuickActionNavigationTest.ts

MonilBhavsar

Thanks!

OSBotify · 2024-12-18T18:34:08Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-12-23T20:57:58Z

🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 9.0.78-0 🚀

platform	result
🤖 android 🤖	cancelled 🔪
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	cancelled 🔪
🍎🔄 iOS HybridApp 🍎🔄	cancelled 🔪

github-actions · 2024-12-23T21:41:54Z

🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 9.0.78-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-12-23T21:49:24Z

🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 9.0.78-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-12-24T00:05:09Z

🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 9.0.78-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-12-24T00:52:48Z

🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 9.0.78-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-12-24T19:42:55Z

🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 9.0.78-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-12-24T19:59:51Z

🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 9.0.78-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-12-26T20:27:06Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.78-6 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

fix qab to navigate with request type

b4c2884

FitseTLT requested a review from a team as a code owner December 11, 2024 15:04

melvin-bot bot requested review from jayeshmangwani and removed request for a team December 11, 2024 15:04

FitseTLT added 3 commits December 13, 2024 17:44

Merge branch 'main' into fix-qab-request-type-navigation-bug

bfc429f

implemented into a util function

06fe5b9

Added tests

ffe383f

jayeshmangwani reviewed Dec 16, 2024

View reviewed changes

src/libs/actions/QuickActionNavigation.ts Outdated Show resolved Hide resolved

jayeshmangwani reviewed Dec 16, 2024

View reviewed changes

tests/unit/QuickActionNavigationTest.ts Outdated Show resolved Hide resolved

jayeshmangwani approved these changes Dec 16, 2024

View reviewed changes

melvin-bot bot requested a review from MonilBhavsar December 16, 2024 09:16

FitseTLT added 3 commits December 16, 2024 16:11

update test

0f7b20d

Merge branch 'main' into fix-qab-request-type-navigation-bug

cd328fb

Merge branch 'main' into fix-qab-request-type-navigation-bug

b466f1e

FitseTLT added 2 commits December 16, 2024 19:44

Merge branch 'main' into fix-qab-request-type-navigation-bug

d62e18e

update variable name

f753014

MonilBhavsar reviewed Dec 17, 2024

View reviewed changes

tests/unit/QuickActionNavigationTest.ts Show resolved Hide resolved

FitseTLT added 2 commits December 17, 2024 17:25

added test comments

0ca67a9

Merge branch 'main' into fix-qab-request-type-navigation-bug

56cbf5f

MonilBhavsar reviewed Dec 17, 2024

View reviewed changes

FitseTLT added 3 commits December 17, 2024 23:51

eslint fix

773a48f

edited comment

ba6f6fd

Merge branch 'main' into fix-qab-request-type-navigation-bug

4b2a8a2

FitseTLT requested a review from MonilBhavsar December 17, 2024 21:01

MonilBhavsar approved these changes Dec 18, 2024

View reviewed changes

MonilBhavsar merged commit 2e8f4fa into Expensify:main Dec 18, 2024
16 checks passed

github-actions bot mentioned this pull request Dec 23, 2024

Deploy Checklist: New Expensify 2024-12-23 #54476

Closed

melvin-bot bot mentioned this pull request Dec 26, 2024

[HOLD for payment 2025-01-02] [$250] QAB- QAB navigates to last opened expense type rather than summited expense #53545

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix - QAB- QAB navigates to last opened expense type rather than summited expense #53945

Fix - QAB- QAB navigates to last opened expense type rather than summited expense #53945

FitseTLT commented Dec 11, 2024 •

edited

Loading

melvin-bot bot commented Dec 11, 2024

jayeshmangwani commented Dec 12, 2024

FitseTLT commented Dec 13, 2024

jayeshmangwani commented Dec 16, 2024

jayeshmangwani left a comment

jayeshmangwani commented Dec 16, 2024

FitseTLT commented Dec 16, 2024

jayeshmangwani commented Dec 16, 2024

jayeshmangwani commented Dec 16, 2024

FitseTLT commented Dec 16, 2024

MonilBhavsar commented Dec 17, 2024

MonilBhavsar left a comment

OSBotify commented Dec 18, 2024

github-actions bot commented Dec 23, 2024

github-actions bot commented Dec 23, 2024

github-actions bot commented Dec 23, 2024

github-actions bot commented Dec 24, 2024

github-actions bot commented Dec 24, 2024

github-actions bot commented Dec 24, 2024

github-actions bot commented Dec 24, 2024

github-actions bot commented Dec 26, 2024

Fix - QAB- QAB navigates to last opened expense type rather than summited expense #53945

Fix - QAB- QAB navigates to last opened expense type rather than summited expense #53945

Conversation

FitseTLT commented Dec 11, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Dec 11, 2024

jayeshmangwani commented Dec 12, 2024

FitseTLT commented Dec 13, 2024

jayeshmangwani commented Dec 16, 2024

Reviewer Checklist

Screenshots/Videos

jayeshmangwani left a comment

Choose a reason for hiding this comment

jayeshmangwani commented Dec 16, 2024

FitseTLT commented Dec 16, 2024

jayeshmangwani commented Dec 16, 2024

jayeshmangwani commented Dec 16, 2024

FitseTLT commented Dec 16, 2024

MonilBhavsar commented Dec 17, 2024

MonilBhavsar left a comment

Choose a reason for hiding this comment

OSBotify commented Dec 18, 2024

github-actions bot commented Dec 23, 2024

github-actions bot commented Dec 23, 2024

github-actions bot commented Dec 23, 2024

github-actions bot commented Dec 24, 2024

github-actions bot commented Dec 24, 2024

github-actions bot commented Dec 24, 2024

github-actions bot commented Dec 24, 2024

github-actions bot commented Dec 26, 2024

FitseTLT commented Dec 11, 2024 •

edited

Loading