Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Replace navigation blur listeners with useFocusEffect" #54244

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Revert "Replace navigation blur listeners with useFocusEffect" #54244

merged 1 commit into from
Dec 17, 2024

Conversation

Julesssss
Copy link
Contributor

Reverts #53735

Trying to locate cause of #54169

@github-actions GitHub Actions
Copy link
Contributor

🚧 @Julesssss has triggered a test build. You can view the workflow run here.

@github-actions GitHub Actions
Copy link
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/54244/index.html https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/54244/index.html
Android iOS
Desktop 💻 Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/54244/NewExpensify.dmg https://54244.pr-testing.expensify.com
Desktop Web

👀 View the workflow run that generated this build 👀

@luacmartins luacmartins marked this pull request as ready for review December 17, 2024 19:12
@luacmartins luacmartins requested a review from a team as a code owner December 17, 2024 19:12
@melvin-bot melvin-bot bot requested a review from Beamanator December 17, 2024 19:12
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Dec 17, 2024

@Beamanator Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot removed the request for review from a team December 17, 2024 19:12
@luacmartins
Copy link
Contributor

Merging to try to identify the cause of #54169

@luacmartins luacmartins merged commit 367e3c3 into main Dec 17, 2024
14 of 16 checks passed
@luacmartins luacmartins deleted the revert-53735-53360-replace-blur-listeners-with-useFocusEffect branch December 17, 2024 19:14
@melvin-bot melvin-bot bot added the Emergency label Dec 17, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Dec 17, 2024

@luacmartins looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

OSBotify pushed a commit that referenced this pull request Dec 17, 2024
@luacmartins @OSBotify
Merge pull request #54244 from Expensify/revert-53735-53360-replace-b…
2a20b05 
…lur-listeners-with-useFocusEffect

Revert "Replace navigation blur listeners with `useFocusEffect`"

(cherry picked from commit 367e3c3)

(CP triggered by luacmartins)
@github-actions github-actions bot added the CP Staging marks PRs that have been CP'd to staging label Dec 17, 2024
@github-actions github-actions bot mentioned this pull request Dec 17, 2024
Closed
60 tasks
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions GitHub Actions
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 9.0.76-9 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 success ✅
🍎🔄 iOS HybridApp 🍎🔄 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@github-actions GitHub Actions
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 9.0.76-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 failure ❌
🍎🔄 iOS HybridApp 🍎🔄 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@luacmartins luacmartins mentioned this pull request Dec 17, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

🚀 Deployed to production by https://github.com/grgia in version: 9.0.76-12 🚀

platform result
🤖 android 🤖 true ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 failure ❌
🍎🔄 iOS HybridApp 🍎🔄 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luacmartins luacmartins luacmartins approved these changes

@Beamanator Beamanator Awaiting requested review from Beamanator

Assignees
No one assigned
Labels
CP Staging marks PRs that have been CP'd to staging Ready To Build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Julesssss @luacmartins @OSBotify