Share extension Android and iOS implementation #54354
+2,299
−10
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,89 @@ | ||
| package com.expensify.chat | ||
|
|
||
| import android.content.Context | ||
| import android.graphics.BitmapFactory | ||
| import android.media.MediaMetadataRetriever | ||
| import com.expensify.chat.intenthandler.IntentHandlerConstants | ||
| import com.facebook.react.bridge.Callback | ||
| import com.facebook.react.bridge.ReactApplicationContext | ||
| import com.facebook.react.bridge.ReactContextBaseJavaModule | ||
| import android.util.Log | ||
| import com.facebook.react.bridge.ReactMethod | ||
| import org.json.JSONObject | ||
| import java.io.File | ||
|
|
||
| class ShareActionHandlerModule(reactContext: ReactApplicationContext) : | ||
| ReactContextBaseJavaModule(reactContext) { | ||
|
|
||
| override fun getName(): String { | ||
| return "ShareActionHandlerModule" | ||
| } | ||
|
|
||
| @ReactMethod | ||
| fun processFiles(callback: Callback) { | ||
| try { | ||
| val sharedPreferences = reactApplicationContext.getSharedPreferences( | ||
| IntentHandlerConstants.preferencesFile, | ||
| Context.MODE_PRIVATE | ||
| ) | ||
|
|
||
| val shareObjectString = sharedPreferences.getString(IntentHandlerConstants.shareObjectProperty, null) | ||
| if (shareObjectString == null) { | ||
| callback.invoke("No data found", null) | ||
| return | ||
| } | ||
|
|
||
| val shareObject = JSONObject(shareObjectString) | ||
| val content = shareObject.optString("content") | ||
| val mimeType = shareObject.optString("mimeType") | ||
| val fileUriPath = "file://$content" | ||
| val timestamp = System.currentTimeMillis() | ||
|
|
||
| val file = File(content) | ||
| if (!file.exists()) { | ||
| val textObject = JSONObject().apply { | ||
| put("id", "text") | ||
| put("content", content) | ||
| put("mimeType", "txt") | ||
| put("processedAt", timestamp) | ||
| } | ||
| callback.invoke(textObject.toString()) | ||
| return | ||
| } | ||
|
|
||
| val identifier = file.name | ||
| var aspectRatio = 0.0f | ||
|
|
||
| if (mimeType.startsWith("image/")) { | ||
| val options = BitmapFactory.Options().apply { inJustDecodeBounds = true } | ||
| BitmapFactory.decodeFile(content, options) | ||
| aspectRatio = if (options.outHeight != 0) options.outWidth.toFloat() / options.outHeight else 1.0f | ||
| } else if (mimeType.startsWith("video/")) { | ||
| val retriever = MediaMetadataRetriever() | ||
| try { | ||
| retriever.setDataSource(content) | ||
| val videoWidth = retriever.extractMetadata(MediaMetadataRetriever.METADATA_KEY_VIDEO_WIDTH)?.toFloatOrNull() ?: 1f | ||
| val videoHeight = retriever.extractMetadata(MediaMetadataRetriever.METADATA_KEY_VIDEO_HEIGHT)?.toFloatOrNull() ?: 1f | ||
| if (videoHeight != 0f) aspectRatio = videoWidth / videoHeight | ||
| } catch (e: Exception) { | ||
| Log.e("ShareActionHandlerModule", "Error retrieving video metadata: ${e.message}") | ||
| } finally { | ||
| retriever.release() | ||
| } | ||
| } | ||
|
|
||
| val fileData = JSONObject().apply { | ||
| put("id", identifier) | ||
| put("content", fileUriPath) | ||
| put("mimeType", mimeType) | ||
| put("processedAt", timestamp) | ||
| put("aspectRatio", aspectRatio) | ||
| } | ||
|
|
||
| callback.invoke(fileData.toString()) | ||
|
|
||
| } catch (e: Exception) { | ||
| callback.invoke(e.toString(), null) | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| package com.expensify.chat.intenthandler | ||
|
|
||
| import android.content.Context | ||
| import com.expensify.chat.utils.FileUtils.clearInternalStorageDirectory | ||
|
|
||
| abstract class AbstractIntentHandler: IntentHandler { | ||
| override fun onCompleted() {} | ||
|
|
||
| protected fun clearTemporaryFiles(context: Context) { | ||
| // Clear data present in the shared preferences | ||
| val sharedPreferences = context.getSharedPreferences(IntentHandlerConstants.preferencesFile, Context.MODE_PRIVATE) | ||
| val editor = sharedPreferences.edit() | ||
| editor.clear() | ||
| editor.apply() | ||
|
|
||
| // Clear leftover temporary files from previous share attempts | ||
| clearInternalStorageDirectory(context) | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| package com.expensify.chat.intenthandler | ||
|
|
||
| import android.content.Context | ||
| import android.content.Intent | ||
| import android.net.Uri | ||
| import com.expensify.chat.utils.FileUtils | ||
|
|
||
| class FileIntentHandler(private val context: Context) : AbstractIntentHandler() { | ||
| override fun handle(intent: Intent): Boolean { | ||
| super.clearTemporaryFiles(context) | ||
| when(intent.action) { | ||
| Intent.ACTION_SEND -> { | ||
| handleSingleFileIntent(intent, context) | ||
| onCompleted() | ||
| return true | ||
| } | ||
| } | ||
| return false | ||
| } | ||
|
|
||
| private fun handleSingleFileIntent(intent: Intent, context: Context) { | ||
| (intent.getParcelableExtra<Uri>(Intent.EXTRA_STREAM))?.let { fileUri -> | ||
| if (fileUri == null) { | ||
| return | ||
| } | ||
|
|
||
| val resultingPath: String? = FileUtils.copyUriToStorage(fileUri, context) | ||
|
|
||
| if (resultingPath != null) { | ||
| val shareFileObject = ShareFileObject(resultingPath, intent.type) | ||
|
|
||
| val sharedPreferences = context.getSharedPreferences(IntentHandlerConstants.preferencesFile, Context.MODE_PRIVATE) | ||
| val editor = sharedPreferences.edit() | ||
| editor.putString(IntentHandlerConstants.shareObjectProperty, shareFileObject.toString()) | ||
| editor.apply() | ||
| } | ||
| } | ||
| } | ||
|
|
||
| override fun onCompleted() { | ||
| val uri: Uri = Uri.parse("new-expensify://share/root") | ||
| val deepLinkIntent = Intent(Intent.ACTION_VIEW, uri) | ||
| deepLinkIntent.flags = Intent.FLAG_ACTIVITY_NEW_TASK | ||
| context.startActivity(deepLinkIntent) | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| package com.expensify.chat.intenthandler | ||
|
|
||
| import android.content.Intent | ||
|
|
||
| object IntentHandlerConstants { | ||
| const val preferencesFile = "shareActionHandler" | ||
| const val shareObjectProperty = "shareObject" | ||
| } | ||
| interface IntentHandler { | ||
| fun handle(intent: Intent): Boolean | ||
| fun onCompleted() | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| package com.expensify.chat.intenthandler | ||
|
|
||
| import android.content.Context | ||
|
|
||
| object IntentHandlerFactory { | ||
| fun getIntentHandler(context: Context, mimeType: String?, rest: String?): IntentHandler? { | ||
| if (mimeType == null) return null | ||
|
|
||
| return when { | ||
| mimeType.matches(Regex("(image|application|audio|video)/.*")) -> FileIntentHandler(context) | ||
| mimeType.startsWith("text/") -> TextIntentHandler(context) | ||
| else -> throw UnsupportedOperationException("Unsupported MIME type: $mimeType") | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| package com.expensify.chat.intenthandler | ||
|
|
||
| import com.google.gson.Gson | ||
|
|
||
| data class ShareFileObject(val content: String, val mimeType: String?) { | ||
| override fun toString(): String { | ||
| return Gson().toJson(this) | ||
|
Comment on lines
+6
to
+7
There was a problem hiding this comment. Do we need to add library for handling json for this line? Wouldn't it be easier just to do something like: override fun toString(): String {
return "{\"content\": ${content}, \"mimeType\": ${mimeType}}"There was a problem hiding this comment. This might work partially, but in case we don't want to add this library we have to handle a few more issues like escaping eg. There was a problem hiding this comment. And what about using |
||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,76 @@ | ||
| package com.expensify.chat.intenthandler | ||
|
|
||
| import android.content.Context | ||
| import android.content.Intent | ||
| import android.net.Uri | ||
| import com.expensify.chat.utils.FileUtils | ||
|
|
||
|
|
||
| class TextIntentHandler(private val context: Context) : AbstractIntentHandler() { | ||
| override fun handle(intent: Intent): Boolean { | ||
| super.clearTemporaryFiles(context) | ||
| when(intent.action) { | ||
| Intent.ACTION_SEND -> { | ||
| handleTextIntent(intent, context) | ||
| onCompleted() | ||
| return true | ||
| } | ||
| } | ||
| return false | ||
| } | ||
|
|
||
| private fun handleTextIntent(intent: Intent, context: Context) { | ||
| when { | ||
| intent.type == "text/plain" -> { | ||
| val extras = intent.extras | ||
| if (extras != null) { | ||
| when { | ||
| extras.containsKey(Intent.EXTRA_STREAM) -> { | ||
| handleTextFileIntent(intent, context) | ||
| } | ||
| extras.containsKey(Intent.EXTRA_TEXT) -> { | ||
| handleTextPlainIntent(intent, context) | ||
| } | ||
| else -> { | ||
| throw UnsupportedOperationException("Unknown text/plain content") | ||
| } | ||
| } | ||
| } | ||
| } | ||
| Regex("text/.*").matches(intent.type ?: "") -> handleTextFileIntent(intent, context) | ||
| else -> throw UnsupportedOperationException("Unsupported MIME type: ${intent.type}") | ||
| } | ||
| } | ||
|
|
||
| private fun saveToSharedPreferences(key: String, value: String) { | ||
| val sharedPreferences = context.getSharedPreferences(IntentHandlerConstants.preferencesFile, Context.MODE_PRIVATE) | ||
| val editor = sharedPreferences.edit() | ||
| editor.putString(key, value) | ||
| editor.apply() | ||
| } | ||
|
|
||
| private fun handleTextFileIntent(intent: Intent, context: Context) { | ||
| (intent.getParcelableExtra<Uri>(Intent.EXTRA_STREAM))?.let { fileUri -> | ||
| val resultingPath: String? = FileUtils.copyUriToStorage(fileUri, context) | ||
| if (resultingPath != null) { | ||
| val shareFileObject = ShareFileObject(resultingPath, intent.type) | ||
| saveToSharedPreferences(IntentHandlerConstants.shareObjectProperty, shareFileObject.toString()) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| private fun handleTextPlainIntent(intent: Intent, context: Context) { | ||
| var intentTextContent = intent.getStringExtra(Intent.EXTRA_TEXT) | ||
| if(intentTextContent != null) { | ||
| val shareFileObject = ShareFileObject(intentTextContent, intent.type) | ||
| saveToSharedPreferences(IntentHandlerConstants.shareObjectProperty, shareFileObject.toString()) | ||
| } | ||
| } | ||
|
|
||
| override fun onCompleted() { | ||
| val uri: Uri = Uri.parse("new-expensify://share/root") | ||
| val deepLinkIntent = Intent(Intent.ACTION_VIEW, uri) | ||
| deepLinkIntent.flags = Intent.FLAG_ACTIVITY_NEW_TASK | ||
| context.startActivity(deepLinkIntent) | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for SNYK to pass we need to use
com.google.code.gson:[email protected]There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done