-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 'trip support' button, so it opens spotnana support page #54963
Fix 'trip support' button, so it opens spotnana support page #54963
Conversation
@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Merged the newest main for you @shubham1206agra |
Already started the review. |
Reviewer Checklist
Screenshots/VideosAndroid: Nativecheck MacOS: Chrome / Safari Android: mWeb Chromecheck MacOS: Chrome / Safari iOS: Nativecheck MacOS: Chrome / Safari iOS: mWeb Safaricheck MacOS: Chrome / Safari MacOS: Chrome / SafariScreen.Recording.2025-01-10.at.3.49.13.PM.movMacOS: Desktopcheck MacOS: Chrome / Safari |
Shall we merge this? @jasperhuangg |
Sorry clicked merge, and GH showed it as merged, but turns out it wasn't 🤦 |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/jasperhuangg in version: 9.0.86-0 🚀
|
@jasperhuangg @blazejkustra We are blocked by the known bug https://github.com/Expensify/Expensify/issues/459996 |
🚀 Deployed to staging by https://github.com/jasperhuangg in version: 9.0.86-0 🚀
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.0.86-3 🚀
|
Explanation of Change
A simple change, so that trip support button redirects to support page.
Fixed Issues
$ #54545
PROPOSAL: N/A
Tests
Precondition:
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
check MacOS: Chrome / Safari
Android: mWeb Chrome
check MacOS: Chrome / Safari
iOS: Native
check MacOS: Chrome / Safari
iOS: mWeb Safari
check MacOS: Chrome / Safari
MacOS: Chrome / Safari
Screen.Recording.2025-01-09.at.10.54.02.mov
MacOS: Desktop
check MacOS: Chrome / Safari