Don't block death nukes with mobile shields. #6296
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Mobile shields blocking ACU explosions gives an obvious snowballing advantage to Aeon and UEF T2, and to an extent Seraphim T3. This advantage should no go into live because it would easily unbalance the game and currently there are no changes made to counteract this newfound advantage.
While it creates inconsistency, it's worth it; the original issue was that ACUs in bases would kill all engis, or that teleporting ACUs would kill all engis, and that is still being solved after these changes. Nobody asked for OP mobile shields, it just came as a consequence of an easy, consistent implementation.
Description of the proposed changes
Implements a
StaticShield
absorption type with automatic mod support based on categories.The default absorption type no longer blocks
DeathNuke
damage, instead theStaticShield
absorption type does. This means modded mobile shields also do not block death nukes. It also opens up a trivial opportunity to addDeathNuke
absorption to the UEF ACU shield, UEF SACU shield, and Fatboy shield.Testing done on the proposed changes
Spawn all static/mobile shields and an engi target underneath them then blow up ACUs to confirm they don't kill the engis.
Spawn units command:
Checklist