Fix being able to pass through invalid ballistic values #6398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Garanas
added a commit
that referenced
this pull request
Aug 9, 2024
## Description of the proposed changes Document the support for method chaining of the projectile engine methods. I noticed this behavior as I was working on #6398. ## Testing done on the proposed changes I called every function and checked the output of the log with logging the instance. If the references match then the function supports method chaining. ``` LOG(self) -- returns memory reference LOG("ChangeDetonateAboveHeight", self:ChangeDetonateAboveHeight(0)) -- returns nil LOG("SetLifetime", self:SetLifetime(10)) -- returns memory reference ``` ## Checklist - [x] Changes are annotated, including comments where useful - [x] Changes are documented in the changelog for the next game version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the proposed changes
If you pass in an invalid value to
SetBallisticAccelerationthen the simulation will freeze up. This is a bug in the engine, but we can 'fix' it in Lua by simply error'ing out if we see such a value.Testing done on the proposed changes
Ran a game and tested/confirmed that regular values are untouched and all variants of invalid values are caught.
Additional context
Possibly related to:
Checklist