Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify the MuzzleVelocity stat of the Aeon Cruiser's missiles #6440

Merged
merged 5 commits into from
Sep 22, 2024

Conversation

Basilisk3
Copy link
Collaborator

@Basilisk3 Basilisk3 commented Sep 9, 2024

Description of the proposed changes

The Infinity Class Cruiser is equipped with two copies of Zealot AA Missile launchers, both of which target the same unit. These two weapons function identically except for the MuzzleVelocity stat, where one weapon has a higher value than the other (though the left weapon also does not have a TargetCheckInterval, and prefers the target of the right weapon). This is misleading because both unit databases show the AA batteries as having a MuzzleVelocity of 40, when in reality, this is only true for one of the launchers. The models on the unit also look identical.

I am not aware of any other unit that does this; the Keefer Class has a MuzzleVelocity of 30 for both of its AA batteries. The UI also does not indicate a difference in MuzzleVelocity between both weapons.

Infinity Class: T2 Cruiser (UAS0202):

  • Zealot AA Missile (right launcher):
    • MuzzleVelocity: 40 --> 35
  • Zealot AA Missile (left launcher):
    • MuzzleVelocity: 30 --> 35

Checklist

  • Changes are documented in the changelog for the next game version

@Basilisk3 Basilisk3 changed the title Unify the MuzzleVelocity stat of the Infinity Class Cruiser's missiles Unify the MuzzleVelocity stat of the Aeon Cruiser's missiles Sep 9, 2024
@lL1l1 lL1l1 mentioned this pull request Sep 19, 2024
Copy link
Member

@Garanas Garanas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the comments.

lua/shared/components/DebugComponent.lua Outdated Show resolved Hide resolved
lua/version.lua Outdated Show resolved Hide resolved
@Basilisk3
Copy link
Collaborator Author

I reverted the changes. I am unsure what caused it, but your explanation makes sense.

@Basilisk3 Basilisk3 requested a review from Garanas September 20, 2024 15:42
@BlackYps BlackYps dismissed Garanas’s stale review September 22, 2024 10:44

Change requests are addressed

@BlackYps BlackYps merged commit c4bc803 into FAForever:develop Sep 22, 2024
5 checks passed
@Basilisk3 Basilisk3 deleted the InfinityClassMuzzleVelocity branch September 22, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants