<feat>(precompiled): add link feature, rm cns. #560

kyonRay · 2022-01-18T09:01:17Z

No description provided.

ghost · 2022-01-18T09:03:54Z

Sider has detected 1 warning on analyzing the commit eb7b35b.

⚠️ Goodcheck

If the errors persist even after retrying, the following actions may resolve them:

Update tool dependencies
Configure failed tools
Configure sider.yml
Turn off unused tools

If you still have problems, feel free to ask us via chat. 💬

You can turn off such notifications if unnecessary.

ghost · 2022-01-18T09:03:55Z

src/main/java/console/contract/ConsoleContractImpl.java

@@ -530,19 +532,25 @@ protected void callContract(
            boolean sm = client.getCryptoSuite().getCryptoTypeConfig() == CryptoType.SM_TYPE;
            // load bin and abi
            if (abiAndBin == null) {
+                String wasmAbiAddress = "";


[PMD Java] The method 'callContract(AbiAndBin, String, String, String, List)' has a cognitive complexity of 22, current threshold is 15 (view)

Rule Ruleset Priority

CognitiveComplexity Design 3

References:

https://pmd.github.io/pmd-6.40.0/pmd_rules_java_design.html#cognitivecomplexity

You can close this issue if no need to fix it. Learn more.

ghost · 2022-01-18T09:03:55Z

src/main/java/console/contract/ConsoleContractImpl.java

-                            contractAddress,
-                            false,
-                            false);
+                            consoleInitializer.getGroupID(), contractName, contractAddress, false);


[PMD Java] The method 'listAbi(ConsoleInitializer, String, String)' has a cognitive complexity of 20, current threshold is 15 (view)

Rule Ruleset Priority

CognitiveComplexity Design 3

References:

https://pmd.github.io/pmd-6.40.0/pmd_rules_java_design.html#cognitivecomplexity

You can close this issue if no need to fix it. Learn more.

ghost · 2022-01-18T09:03:55Z

src/main/java/console/precompiled/PrecompiledImpl.java

            return;
        }
-        List<FileInfo> listResult;
+        List<BfsInfo> listResult;


[PMD Java] The method 'changeDir(String, String)' has a cognitive complexity of 15, current threshold is 15 (view)

Rule Ruleset Priority

CognitiveComplexity Design 3

References:

https://pmd.github.io/pmd-6.40.0/pmd_rules_java_design.html#cognitivecomplexity

You can close this issue if no need to fix it. Learn more.

ghost · 2022-01-18T09:03:55Z

src/main/java/console/precompiled/PrecompiledImpl.java

@@ -751,7 +729,7 @@ public void pwd(String pwd) {
        if (deep >= limit) return new Tuple2<>(0, 0);
        Integer dirCount = 0;
        Integer contractCount = 0;
-        List<FileInfo> children = bfsService.list(absolutePath);
+        List<BfsInfo> children = bfsService.list(absolutePath);


[PMD Java] The method 'travelBfs(String, String, int, int)' has a cognitive complexity of 17, current threshold is 15 (view)

Rule Ruleset Priority

CognitiveComplexity Design 3

References:

https://pmd.github.io/pmd-6.40.0/pmd_rules_java_design.html#cognitivecomplexity

You can close this issue if no need to fix it. Learn more.

ghost · 2022-01-18T09:03:55Z

src/main/java/console/command/SupportedCommand.java

-                    2,
-                    true,
-                    false);
+                    -1);


[PMD Java] Avoid really long classes. (view)

Rule Ruleset Priority

ExcessiveClassLength Design 3

References:

https://pmd.github.io/pmd-6.40.0/pmd_rules_java_design.html#excessiveclasslength

You can close this issue if no need to fix it. Learn more.

ghost · 2022-01-18T09:03:56Z

src/main/java/console/command/model/HelpInfo.java

-        System.out.println(
-                "* NodeEndPoint[Optional] -- The requested node information, the format is IP:Port, "
-                        + "the list of all connected nodes can be obtained through getAvailableConnections");
+        System.out.println("Query all group peers");


[PMD Java] This class has a bunch of public methods and attributes (view)

Rule Ruleset Priority

ExcessivePublicCount Design 3

References:

https://pmd.github.io/pmd-6.40.0/pmd_rules_java_design.html#excessivepubliccount

You can close this issue if no need to fix it. Learn more.

ghost · 2022-01-18T09:03:56Z

src/main/java/console/contract/ConsoleContractImpl.java

@@ -559,16 +567,16 @@ protected void callContract(
            if (abiDefinition.isConstant()) {
                logger.debug(
                        "sendCall request, params: {}, contractAddress: {}, contractName: {}, functionName:{}, paramSize: {}",
-                        callParams.toString(),
-                        this.client.isWASM() ? contractNameOrPath : contractAddress,
+                        callParams,


[PMD Java] Logger calls should be surrounded by log level guards. (view)

Rule Ruleset Priority

GuardLogStatement Best Practices 2

References:

https://pmd.github.io/pmd-6.40.0/pmd_rules_java_bestpractices.html#guardlogstatement

You can close this issue if no need to fix it. Learn more.

ghost · 2022-01-18T09:03:56Z

src/main/java/console/contract/ConsoleContractImpl.java

@@ -594,18 +602,15 @@ protected void callContract(
            else {
                logger.trace(
                        "sendTransactionAndGetResponse request, params: {}, contractAddress: {}, contractName: {}, functionName: {}, paramSize:{},  abiDefinition: {}",
-                        callParams.toString(),
-                        this.client.isWASM() ? contractNameOrPath : contractAddress,
+                        callParams,


[PMD Java] Logger calls should be surrounded by log level guards. (view)

Rule Ruleset Priority

GuardLogStatement Best Practices 2

References:

https://pmd.github.io/pmd-6.40.0/pmd_rules_java_bestpractices.html#guardlogstatement

You can close this issue if no need to fix it. Learn more.

ghost · 2022-01-18T09:03:56Z

src/main/java/console/precompiled/PrecompiledImpl.java

+                            client.getGroup(), contractName, contractAddress, sm);
+            abi = abiAndBin.getAbi();
+        } catch (CompileContractException e) {
+            logger.warn(


[PMD Java] Logger calls should be surrounded by log level guards. (view)

Rule Ruleset Priority

GuardLogStatement Best Practices 2

References:

https://pmd.github.io/pmd-6.40.0/pmd_rules_java_bestpractices.html#guardlogstatement

You can close this issue if no need to fix it. Learn more.

ghost · 2022-01-18T12:18:36Z

src/main/java/console/contract/ConsoleContractImpl.java

-                            contractAddress,
-                            false,
-                            false);
+                            consoleInitializer.getGroupID(), contractName, contractAddress, false);


[PMD Java] The method 'listAbi(ConsoleInitializer, String, String)' has a cognitive complexity of 20, current threshold is 15 (view)

Rule Ruleset Priority

CognitiveComplexity Design 3

References:

https://pmd.github.io/pmd-6.40.0/pmd_rules_java_design.html#cognitivecomplexity

You can close this issue if no need to fix it. Learn more.

ghost · 2022-01-18T12:18:36Z

src/main/java/console/precompiled/PrecompiledImpl.java

+                    contractAddress,
+                    e.getMessage());
+        }
+        if (abi.equals("")) {


[Checkstyle] String literal expressions should be on the left side of an equals comparison. (view)

Rule Severity

EqualsAvoidNullCheck info

References:

https://checkstyle.org/config_coding.html#EqualsAvoidNull

You can close this issue if no need to fix it. Learn more.

ghost · 2022-01-18T12:18:37Z

src/main/java/console/precompiled/PrecompiledImpl.java

+                            client.getGroup(), contractName, contractAddress, sm);
+            abi = abiAndBin.getAbi();
+        } catch (CompileContractException e) {
+            logger.error(


[PMD Java] Logger calls should be surrounded by log level guards. (view)

Rule Ruleset Priority

GuardLogStatement Best Practices 2

References:

https://pmd.github.io/pmd-6.40.0/pmd_rules_java_bestpractices.html#guardlogstatement

You can close this issue if no need to fix it. Learn more.

sonarqubecloud · 2022-01-19T02:35:06Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

ghost · 2022-01-19T02:37:22Z

src/main/java/console/precompiled/PrecompiledImpl.java

@@ -751,7 +729,7 @@ public void pwd(String pwd) {
        if (deep >= limit) return new Tuple2<>(0, 0);
        Integer dirCount = 0;
        Integer contractCount = 0;
-        List<FileInfo> children = bfsService.list(absolutePath);
+        List<BfsInfo> children = bfsService.list(absolutePath);


[PMD Java] The method 'travelBfs(String, String, int, int)' has a cognitive complexity of 17, current threshold is 15 (view)

Rule Ruleset Priority

CognitiveComplexity Design 3

References:

https://pmd.github.io/pmd-6.40.0/pmd_rules_java_design.html#cognitivecomplexity

You can close this issue if no need to fix it. Learn more.

ywy2090 approved these changes Jan 18, 2022

View reviewed changes

ghost reviewed Jan 18, 2022

View reviewed changes

cyjseagull approved these changes Jan 18, 2022

View reviewed changes

bxq2011hust approved these changes Jan 18, 2022

View reviewed changes

kyonRay force-pushed the feature-3.0.0-rc3 branch 2 times, most recently from 81bf07f to 66019d4 Compare January 18, 2022 12:15

ghost reviewed Jan 18, 2022

View reviewed changes

kyonRay force-pushed the feature-3.0.0-rc3 branch from 66019d4 to 52a9146 Compare January 19, 2022 02:32

<feat>(precompiled): add link feature, rm cns.

eb7b35b

kyonRay force-pushed the feature-3.0.0-rc3 branch from 52a9146 to eb7b35b Compare January 19, 2022 02:34

ghost reviewed Jan 19, 2022

View reviewed changes

kyonRay merged commit 7a9baca into FISCO-BCOS:feature-3.0.0-rc3 Jan 19, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

<feat>(precompiled): add link feature, rm cns. #560

<feat>(precompiled): add link feature, rm cns. #560

kyonRay commented Jan 18, 2022

ghost commented Jan 18, 2022 •

edited by ghost

Loading

ghost Jan 18, 2022

ghost Jan 18, 2022

ghost Jan 18, 2022

ghost Jan 18, 2022

ghost Jan 18, 2022

ghost Jan 18, 2022

ghost Jan 18, 2022

ghost Jan 18, 2022

ghost Jan 18, 2022

ghost Jan 18, 2022

ghost Jan 18, 2022

ghost Jan 18, 2022

sonarqubecloud bot commented Jan 19, 2022

ghost Jan 19, 2022

<feat>(precompiled): add link feature, rm cns. #560

<feat>(precompiled): add link feature, rm cns. #560

Conversation

kyonRay commented Jan 18, 2022

ghost commented Jan 18, 2022 • edited by ghost Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Jan 19, 2022

Choose a reason for hiding this comment

ghost commented Jan 18, 2022 •

edited by ghost

Loading