release 3.0.0-rc2 #568

cyjseagull · 2022-02-22T03:06:49Z

No description provided.

update java-sdk version

…#549)

…CO-BCOS#550) * <fix>(console): fix bfs command completer. * <fix>(jline): fix bfs commands completer.

update java sdk version

update log4j2 version to 2.17.1

<fix>(console): fix auth init bug, fix cd command bug.

<fix>(console): fix wasm getCode bug, fix get transaction receipt bug.

sonarqubecloud · 2022-02-22T03:07:10Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

ghost · 2022-02-22T03:09:21Z

Sider has detected 1 warning on analyzing the commit 1eb3e18.

⚠️ Goodcheck

If the errors persist even after retrying, the following actions may resolve them:

Update tool dependencies
Configure failed tools
Configure sider.yml
Turn off unused tools

If you still have problems, feel free to ask us via chat. 💬

You can turn off such notifications if unnecessary.

ghost · 2022-02-22T03:09:22Z

src/main/java/console/common/ConsoleUtils.java

+            if (param.startsWith("~")) {
+                pathToFix = "/apps/" + param.substring(1);
+            } else {
+                pathToFix = pwd + ((pwd.equals("/")) ? "" : "/") + param;


[Checkstyle] String literal expressions should be on the left side of an equals comparison. (view)

Rule Severity

EqualsAvoidNullCheck info

References:

https://checkstyle.org/config_coding.html#EqualsAvoidNull

You can close this issue if no need to fix it. Learn more.

ghost · 2022-02-22T03:09:22Z

src/main/java/console/precompiled/PrecompiledImpl.java

+                    Tuple2<Integer, Integer> childCount =
+                            travelBfs(
+                                    absolutePath
+                                            + (absolutePath.equals("/") ? "" : "/")


[Checkstyle] String literal expressions should be on the left side of an equals comparison. (view)

Rule Severity

EqualsAvoidNullCheck info

References:

https://checkstyle.org/config_coding.html#EqualsAvoidNull

You can close this issue if no need to fix it. Learn more.

ghost · 2022-02-22T03:09:22Z

src/main/java/console/command/SupportedCommand.java

-                        (consoleInitializer, params, pwd) ->
-                                consoleInitializer.getPrecompiledFace().remove(params[0]));
-     */
+    // TODO: Table CRUD service is not supported in FISCO BCOS 3.0.0 rc1


[Checkstyle] Comment matches to-do format 'TODO:'. (view)

Rule Severity

TodoCommentCheck info

References:

https://checkstyle.org/config_misc.html#TodoComment

You can close this issue if no need to fix it. Learn more.

ghost · 2022-02-22T03:09:22Z

src/main/java/console/Console.java

@@ -58,8 +58,10 @@ public static void main(String[] args) {
        }

        WelcomeInfo.welcome();
-        String pwd = "/";
-        SupportedCommand.setIsAuthOpen(consoleInitializer.getClient().isAuthCheck());
+        String pwd = "/apps";


[PMD Java] The method 'main(String)' has a cognitive complexity of 81, current threshold is 15 (view)

Rule Ruleset Priority

CognitiveComplexity Design 3

References:

https://pmd.github.io/pmd-6.40.0/pmd_rules_java_design.html#cognitivecomplexity

You can close this issue if no need to fix it. Learn more.

ghost · 2022-02-22T03:09:22Z

src/main/java/console/contract/ConsoleContractImpl.java

-                //                CnsInfo latestCNSInfo = cnsInfos.get(cnsInfos.size() - 1);
-                //                contractAddress = latestCNSInfo.getAddress();
-                //                contractAbi = latestCNSInfo.getAbi();
+                List<CnsInfo> cnsInfos = cnsService.selectByName(contractName);


[PMD Java] The method 'callByCNS(String)' has a cognitive complexity of 17, current threshold is 15 (view)

Rule Ruleset Priority

CognitiveComplexity Design 3

References:

https://pmd.github.io/pmd-6.40.0/pmd_rules_java_design.html#cognitivecomplexity

You can close this issue if no need to fix it. Learn more.

ghost · 2022-02-22T03:09:23Z

src/main/java/console/precompiled/PrecompiledImpl.java

    @Override
    public void pwd(String pwd) {
        System.out.println(pwd);
    }
+
+    private Tuple2<Integer, Integer> travelBfs(


[PMD Java] The method 'travelBfs(String, String, int, int)' has a cognitive complexity of 17, current threshold is 15 (view)

Rule Ruleset Priority

CognitiveComplexity Design 3

References:

https://pmd.github.io/pmd-6.40.0/pmd_rules_java_design.html#cognitivecomplexity

You can close this issue if no need to fix it. Learn more.

ghost · 2022-02-22T03:09:23Z

src/main/java/console/command/SupportedCommand.java

-                        (consoleInitializer, params, pwd) ->
-                                consoleInitializer.getPrecompiledFace().remove(params[0]));
-     */
+    // TODO: Table CRUD service is not supported in FISCO BCOS 3.0.0 rc1


[PMD Java] Avoid really long classes. (view)

Rule Ruleset Priority

ExcessiveClassLength Design 3

References:

https://pmd.github.io/pmd-6.40.0/pmd_rules_java_design.html#excessiveclasslength

You can close this issue if no need to fix it. Learn more.

ghost · 2022-02-22T03:09:23Z

src/main/java/console/command/model/HelpInfo.java

@@ -283,7 +283,7 @@ public static void deployHelp(boolean isWasm) {
            System.out.println(
                    "* abi -- The path of ABI file after contract being compiled via cargo-liquid.");
            System.out.println(
-                    "* path -- The path of BFS where the contract will be located at, such as /apps/liquid/YouContract/");
+                    "* path -- The path of BFS where the contract will be located at, such as '/apps/liquid/YouContract/'.");


[PMD Java] This class has a bunch of public methods and attributes (view)

Rule Ruleset Priority

ExcessivePublicCount Design 3

References:

https://pmd.github.io/pmd-6.40.0/pmd_rules_java_design.html#excessivepubliccount

You can close this issue if no need to fix it. Learn more.

ghost · 2022-02-22T03:09:23Z

src/main/java/console/command/SupportedCommand.java

@@ -971,13 +984,13 @@ public void printUsageInfo() {
                            LIST_DIR.getCommand(),
                            CHANGE_DIR.getCommand(),
                            MAKE_DIR.getCommand(),
-                            PWD.getCommand()));
+                            TREE.getCommand()));


[PMD Java] Do not use non-final non-private static fields (view)

Rule Ruleset Priority

MutableStaticState Design 3

References:

https://pmd.github.io/pmd-6.40.0/pmd_rules_java_design.html#mutablestaticstate

You can close this issue if no need to fix it. Learn more.

ghost · 2022-02-22T03:09:23Z

src/main/java/console/command/SupportedCommand.java


    // TODO: Table CRUD service is not supported in FISCO BCOS 3.0.0 rc1
    public static List<String> CRUD_COMMANDS =
            new ArrayList<>(
                    Arrays.asList(
-                            // CREATE.getCommand(),
+                            CREATE.getCommand()


[PMD Java] Do not use non-final non-private static fields (view)

Rule Ruleset Priority

MutableStaticState Design 3

References:

https://pmd.github.io/pmd-6.40.0/pmd_rules_java_design.html#mutablestaticstate

You can close this issue if no need to fix it. Learn more.

ywy2090 and others added 19 commits December 17, 2021 12:48

update java-sdk version

46a8fbf

Merge pull request FISCO-BCOS#546 from ywy2090/dev

51bf039

update java-sdk version

<fix>(auth): fix auth show bug. (FISCO-BCOS#547)

786ad98

<fix>(precompiled): fix CNS bug, add bfs home to /apps. (FISCO-BCOS#548)

671cde6

<fix>(console): add governor weight limit and size limit. (FISCO-BCOS…

10df71d

…#549)

<fix>(jline): fix bfs commands completer, add kv table commands. (FIS…

71bafb6

…CO-BCOS#550) * <fix>(console): fix bfs command completer. * <fix>(jline): fix bfs commands completer.

<feat>(command): add bfs tree commands. (FISCO-BCOS#551)

7bba01e

update java sdk version

cd20909

Merge pull request FISCO-BCOS#553 from ywy2090/release-3.0.0-rc2

4b2f132

update java sdk version

<fix>(precompiled): fix cns get latest version bug. (FISCO-BCOS#554)

7d54fca

<fix>(resource): rename default group name to group0. (FISCO-BCOS#556)

5373966

update log4j2 version to 2.17.1

ce959fb

Merge pull request FISCO-BCOS#558 from ywy2090/release-3.0.0-rc2

d8b44ad

update log4j2 version to 2.17.1

fix compile error (FISCO-BCOS#559)

20cef8b

<fix>(console): fix auth init bug, fix cd command bug.

5f78920

Merge pull request FISCO-BCOS#562 from kyonRay/release-3.0.0-rc2

65383ca

<fix>(console): fix auth init bug, fix cd command bug.

<fix>(console): fix wasm getCode bug.

74e1edb

<fix>(console): fix transaction receipt bug.

5bf5d25

Merge pull request FISCO-BCOS#564 from kyonRay/release-3.0.0-rc2

1eb3e18

<fix>(console): fix wasm getCode bug, fix get transaction receipt bug.

cyjseagull requested review from kyonRay and ywy2090 February 22, 2022 03:06

cyjseagull added release 3.0.0-rc2 labels Feb 22, 2022

ghost reviewed Feb 22, 2022

View reviewed changes

kyonRay approved these changes Feb 22, 2022

View reviewed changes

JimmyShi22 approved these changes Feb 22, 2022

View reviewed changes

ywy2090 approved these changes Feb 22, 2022

View reviewed changes

cyjseagull merged commit 5cc7bcb into FISCO-BCOS:master Feb 22, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

release 3.0.0-rc2 #568

release 3.0.0-rc2 #568

cyjseagull commented Feb 22, 2022

sonarqubecloud bot commented Feb 22, 2022

ghost commented Feb 22, 2022

ghost Feb 22, 2022

ghost Feb 22, 2022

ghost Feb 22, 2022

ghost Feb 22, 2022

ghost Feb 22, 2022

ghost Feb 22, 2022

ghost Feb 22, 2022

ghost Feb 22, 2022

ghost Feb 22, 2022

ghost Feb 22, 2022

release 3.0.0-rc2 #568

release 3.0.0-rc2 #568

Conversation

cyjseagull commented Feb 22, 2022

sonarqubecloud bot commented Feb 22, 2022

ghost commented Feb 22, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment