<feat>(command): add alter table command. #629
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
|
Sider has detected 1 warning on analyzing the commit 8b6b403.
If the errors persist even after retrying, the following actions may resolve them:
If you still have problems, feel free to ask us via chat. 💬 You can turn off such notifications if unnecessary. |
| } catch (ConsoleMessageException e) { | ||
| System.out.println(e.getMessage()); | ||
| logger.error(" message: {}, e:", e.getMessage(), e); | ||
| } catch (JSQLParserException | NullPointerException e) { |
There was a problem hiding this comment.
[PMD Java] Avoid catching NullPointerException; consider removing the cause of the NPE. (view)
| Rule | Ruleset | Priority |
|---|---|---|
AvoidCatchingNPE |
Error Prone | 3 |
References:
You can close this issue if no need to fix it. Learn more.
| return true; | ||
| } | ||
|
|
||
| private void outputErrorMessageForTableCRUD( |
There was a problem hiding this comment.
[PMD Java] The method 'outputErrorMessageForTableCRUD(Table, String, Entry, String, int, String, Map)' has a cognitive complexity of 20, current threshold is 15 (view)
| Rule | Ruleset | Priority |
|---|---|---|
CognitiveComplexity |
Design | 3 |
References:
You can close this issue if no need to fix it. Learn more.
| @@ -171,7 +171,14 @@ public void printUsageInfo() { | |||
| "create", | |||
| "Create table by sql", | |||
| (consoleInitializer, params, pwd) -> | |||
| consoleInitializer.getPrecompiledFace().createTable(params[0], isWasm)); | |||
| consoleInitializer.getPrecompiledFace().createTable(params[0])); | |||
There was a problem hiding this comment.
[PMD Java] Avoid really long classes. (view)
| Rule | Ruleset | Priority |
|---|---|---|
ExcessiveClassLength |
Design | 3 |
References:
You can close this issue if no need to fix it. Learn more.
| } | ||
| } catch (ConsoleMessageException e) { | ||
| System.out.println(e.getMessage()); | ||
| logger.error(" message: {}, e:", e.getMessage(), e); |
There was a problem hiding this comment.
[PMD Java] Logger calls should be surrounded by log level guards. (view)
| Rule | Ruleset | Priority |
|---|---|---|
GuardLogStatement |
Best Practices | 2 |
References:
You can close this issue if no need to fix it. Learn more.
| System.out.println(e.getMessage()); | ||
| logger.error(" message: {}, e:", e.getMessage(), e); | ||
| } catch (JSQLParserException | NullPointerException e) { | ||
| logger.error(" message: {}, e:", e.getMessage(), e); |
There was a problem hiding this comment.
[PMD Java] Logger calls should be surrounded by log level guards. (view)
| Rule | Ruleset | Priority |
|---|---|---|
GuardLogStatement |
Best Practices | 2 |
References:
You can close this issue if no need to fix it. Learn more.
| e.getErrorCode(), | ||
| e.getMessage(), | ||
| null); | ||
| } catch (ClientException e) { |
There was a problem hiding this comment.
[PMD Java] 'catch' branch identical to 'ContractException' branch (view)
| Rule | Ruleset | Priority |
|---|---|---|
IdenticalCatchBranches |
Code Style | 3 |
References:
You can close this issue if no need to fix it. Learn more.
| @@ -1077,6 +1084,7 @@ public void printUsageInfo() { | |||
| new ArrayList<>( | |||
| Arrays.asList( | |||
| CREATE.getCommand(), | |||
| ALTER.getCommand(), | |||
There was a problem hiding this comment.
[PMD Java] Do not use non-final non-private static fields (view)
| Rule | Ruleset | Priority |
|---|---|---|
MutableStaticState |
Design | 3 |
References:
You can close this issue if no need to fix it. Learn more.
No description provided.