Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<refactor>(command): refactor commands to categoies. #630

Merged
merged 1 commit into from
Jun 14, 2022
Merged

<refactor>(command): refactor commands to categoies. #630

merged 1 commit into from
Jun 14, 2022

Conversation

kyonRay
Copy link
Member

@kyonRay kyonRay commented Jun 13, 2022

No description provided.

@ghost
Copy link

ghost commented Jun 13, 2022 •
edited by ghost
Loading

Sider has detected 2 warnings on analyzing the commit 739123a.

  • ⚠️ Goodcheck
  • ⚠️ The number of issues (56) exceeded the limit of comments. Please visit Sider to review the issues.

If the errors persist even after retrying, the following actions may resolve them:

If you still have problems, feel free to ask us via chat. 💬

You can turn off such notifications if unnecessary.

ghost
ghost reviewed Jun 13, 2022
View reviewed changes
src/main/java/console/command/category/AccountOpCommand.java Outdated
commandToCommandInfo.put(s, constantCommandInfo);
}
}
} catch (IllegalAccessException ignored) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Checkstyle] Empty catch block. (view)

Rule Severity
EmptyCatchBlockCheck info

References:

You can close this issue if no need to fix it. Learn more.

src/main/java/console/command/category/AuthOpCommand.java Outdated
commandToCommandInfo.put(s, constantCommandInfo);
}
}
} catch (IllegalAccessException ignored) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Checkstyle] Empty catch block. (view)

Rule Severity
EmptyCatchBlockCheck info

References:

You can close this issue if no need to fix it. Learn more.

src/main/java/console/command/category/BasicCommand.java Outdated
commandToCommandInfo.put(s, constantCommandInfo);
}
}
} catch (IllegalAccessException ignored) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Checkstyle] Empty catch block. (view)

Rule Severity
EmptyCatchBlockCheck info

References:

You can close this issue if no need to fix it. Learn more.

src/main/java/console/command/category/BfsCommand.java Outdated
commandToCommandInfo.put(s, constantCommandInfo);
}
}
} catch (IllegalAccessException ignored) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Checkstyle] Empty catch block. (view)

Rule Severity
EmptyCatchBlockCheck info

References:

You can close this issue if no need to fix it. Learn more.

src/main/java/console/command/category/CollaborationOpCommand.java Outdated
commandToCommandInfo.put(s, constantCommandInfo);
}
}
} catch (IllegalAccessException ignored) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Checkstyle] Empty catch block. (view)

Rule Severity
EmptyCatchBlockCheck info

References:

You can close this issue if no need to fix it. Learn more.

src/main/java/console/command/SupportedCommand.java Outdated
}
}

public static BasicCommand basicCommand = new BasicCommand();
public static ContractOpCommand contractOpCommand = new ContractOpCommand();
public static StatusQueryCommand statusQueryCommand = new StatusQueryCommand();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[PMD Java] Do not use non-final non-private static fields (view)

Rule Ruleset Priority
MutableStaticState Design 3

References:

You can close this issue if no need to fix it. Learn more.

src/main/java/console/command/SupportedCommand.java Outdated
public static BasicCommand basicCommand = new BasicCommand();
public static ContractOpCommand contractOpCommand = new ContractOpCommand();
public static StatusQueryCommand statusQueryCommand = new StatusQueryCommand();
public static ConsensusOpCommand consensusOpCommand = new ConsensusOpCommand();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[PMD Java] Do not use non-final non-private static fields (view)

Rule Ruleset Priority
MutableStaticState Design 3

References:

You can close this issue if no need to fix it. Learn more.

src/main/java/console/command/SupportedCommand.java Outdated
public static ContractOpCommand contractOpCommand = new ContractOpCommand();
public static StatusQueryCommand statusQueryCommand = new StatusQueryCommand();
public static ConsensusOpCommand consensusOpCommand = new ConsensusOpCommand();
public static BfsCommand bfsCommand = new BfsCommand();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[PMD Java] Do not use non-final non-private static fields (view)

Rule Ruleset Priority
MutableStaticState Design 3

References:

You can close this issue if no need to fix it. Learn more.

src/main/java/console/command/SupportedCommand.java Outdated
public static StatusQueryCommand statusQueryCommand = new StatusQueryCommand();
public static ConsensusOpCommand consensusOpCommand = new ConsensusOpCommand();
public static BfsCommand bfsCommand = new BfsCommand();
public static CrudCommand crudCommand = new CrudCommand();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[PMD Java] Do not use non-final non-private static fields (view)

Rule Ruleset Priority
MutableStaticState Design 3

References:

You can close this issue if no need to fix it. Learn more.

src/main/java/console/command/SupportedCommand.java Outdated
public static ConsensusOpCommand consensusOpCommand = new ConsensusOpCommand();
public static BfsCommand bfsCommand = new BfsCommand();
public static CrudCommand crudCommand = new CrudCommand();
public static GroupCommand groupCommand = new GroupCommand();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[PMD Java] Do not use non-final non-private static fields (view)

Rule Ruleset Priority
MutableStaticState Design 3

References:

You can close this issue if no need to fix it. Learn more.

@kyonRay kyonRay force-pushed the release-3.0.0-rc4 branch from cfe97c7 to 1223d7d Compare June 13, 2022 16:37
ghost
ghost reviewed Jun 13, 2022
View reviewed changes
src/main/java/console/command/category/AccountOpCommand.java Outdated
import java.util.stream.Collectors;

public class AccountOpCommand extends BasicCategoryCommand {
protected static Map<String, CommandInfo> commandToCommandInfo = new HashMap<>();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[PMD Java] Do not use non-final non-private static fields (view)

Rule Ruleset Priority
MutableStaticState Design 3

References:

You can close this issue if no need to fix it. Learn more.

src/main/java/console/command/category/AuthOpCommand.java Outdated
import java.util.Map;

public class AuthOpCommand extends BasicCategoryCommand {
protected static Map<String, CommandInfo> commandToCommandInfo = new HashMap<>();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[PMD Java] Do not use non-final non-private static fields (view)

Rule Ruleset Priority
MutableStaticState Design 3

References:

You can close this issue if no need to fix it. Learn more.

src/main/java/console/command/category/BasicCommand.java Outdated
import java.util.stream.Collectors;

public class BasicCommand extends BasicCategoryCommand {
protected static Map<String, CommandInfo> commandToCommandInfo = new HashMap<>();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[PMD Java] Do not use non-final non-private static fields (view)

Rule Ruleset Priority
MutableStaticState Design 3

References:

You can close this issue if no need to fix it. Learn more.

src/main/java/console/command/category/BfsCommand.java Outdated
import java.util.stream.Collectors;

public class BfsCommand extends BasicCategoryCommand {
protected static Map<String, CommandInfo> commandToCommandInfo = new HashMap<>();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[PMD Java] Do not use non-final non-private static fields (view)

Rule Ruleset Priority
MutableStaticState Design 3

References:

You can close this issue if no need to fix it. Learn more.

src/main/java/console/command/category/CollaborationOpCommand.java Outdated
import java.util.Map;

public class CollaborationOpCommand extends BasicCategoryCommand {
protected static Map<String, CommandInfo> commandToCommandInfo = new HashMap<>();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[PMD Java] Do not use non-final non-private static fields (view)

Rule Ruleset Priority
MutableStaticState Design 3

References:

You can close this issue if no need to fix it. Learn more.

src/main/java/console/command/category/BfsCommand.java Outdated
}
}

public static List<String> BFS_COMMANDS =
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Checkstyle] Name 'BFS_COMMANDS' must match pattern '^[a-z][a-zA-Z0-9]*$'. (view)

Rule Severity
StaticVariableNameCheck info

References:

You can close this issue if no need to fix it. Learn more.

src/main/java/console/command/category/CollaborationOpCommand.java Outdated
}

// TODO: Liquid collaboration service is not supported in FISCO BCOS 3.0.0 rc4
public static List<String> COLLABORATION_COMMANDS =
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Checkstyle] Name 'COLLABORATION_COMMANDS' must match pattern '^[a-z][a-zA-Z0-9]*$'. (view)

Rule Severity
StaticVariableNameCheck info

References:

You can close this issue if no need to fix it. Learn more.

src/main/java/console/command/category/ConsensusOpCommand.java Outdated
}
}

public static List<String> CONSENSUS_COMMANDS =
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Checkstyle] Name 'CONSENSUS_COMMANDS' must match pattern '^[a-z][a-zA-Z0-9]*$'. (view)

Rule Severity
StaticVariableNameCheck info

References:

You can close this issue if no need to fix it. Learn more.

src/main/java/console/command/category/CrudCommand.java Outdated
}
}

public static List<String> CRUD_COMMANDS =
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Checkstyle] Name 'CRUD_COMMANDS' must match pattern '^[a-z][a-zA-Z0-9]*$'. (view)

Rule Severity
StaticVariableNameCheck info

References:

You can close this issue if no need to fix it. Learn more.

src/main/java/console/command/category/CollaborationOpCommand.java
}
}

// TODO: Liquid collaboration service is not supported in FISCO BCOS 3.0.0 rc4
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Checkstyle] Comment matches to-do format 'TODO:'. (view)

Rule Severity
TodoCommentCheck info

References:

You can close this issue if no need to fix it. Learn more.

@kyonRay kyonRay force-pushed the release-3.0.0-rc4 branch 2 times, most recently from 3dd341c to 68100fc Compare June 13, 2022 17:05
@kyonRay kyonRay force-pushed the release-3.0.0-rc4 branch from 68100fc to 739123a Compare June 14, 2022 05:16
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kyonRay kyonRay merged commit 47271cb into FISCO-BCOS:release-3.0.0-rc4 Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bxq2011hust bxq2011hust bxq2011hust approved these changes

@ywy2090 ywy2090 ywy2090 approved these changes

@cyjseagull cyjseagull cyjseagull approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kyonRay @cyjseagull @ywy2090 @bxq2011hust