Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Calendar page #85

Merged
merged 2 commits into from
Mar 7, 2020
Merged

Add Calendar page #85

merged 2 commits into from
Mar 7, 2020

Conversation

ct-martin
Copy link
Member

Based on RITlug site calendar. I leave it to you to choose where to link (outside this PR).

@jwflory jwflory requested a review from a team January 14, 2020 16:22
@jwflory jwflory added the new change Adds new capabilities or functionality label Jan 14, 2020
@jwflory
Copy link
Member

jwflory commented Jan 14, 2020

Thanks @ct-martin. I'll try to review this by the end of the week. I also requested review by the Tech Team since I am not particularly web-savvy.

@Nolski Nolski self-assigned this Jan 14, 2020
@Tjzabel
Copy link
Member

Tjzabel commented Jan 14, 2020

This is essentially verbatim the RITlug website PR that we merged a few days ago. You can see the merged view here.

I'll leave it to you guys to approve.

Copy link
Member

@jwflory jwflory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ct-martin, I had a chance to test this today. Looks good! 🎉 I have a few changes I'd like to see before merging:

  1. Documentation about how to add new events to the calendar in the CONTRIBUTING.md file (appending to the bottom is fine)
  2. Add link to "Calendar" in the upper-navigation and footer (between "Announcements" and "Events")

Once these are done, I'll merge this PR. Thanks for working on this!

@ct-martin
Copy link
Member Author

@jwflory

  1. I asked you offline at BrickHack, but calendar is based on well-formed metadata (frontmatter) of posts. Since this isn't specific to the calendar and is more of documentation on how to write a post, would you like it in README.md or CONTRIBUTING.md? Also, I am of the opinion that it's better to keep this information in the repo than the runbook due to the fact there there are implementation details in the explanations. See the RITlug README for what this would look like
  2. We've actually hit the limit of how much as can fit in the navbar, do you mind merging this and continuing the discussion in another PR? I doubt you want to remove anything, but adding dropdowns to the navbar will be beyond the scope of this PR.
    Screen Shot 2020-02-13 at 12 09 28

@jwflory
Copy link
Member

jwflory commented Mar 7, 2020

Hey @ct-martin, could you please rebase this PR on the latest master branch? I'll document the how-to piece in the Runbook along with the other website content and we can move this PR along. Thanks for being patient.

@jwflory jwflory self-requested a review March 7, 2020 14:30
@ct-martin
Copy link
Member Author

@jwflory done. In particular, please note the date-start and date-end frontmatter when you're updating the runbook (this is in the RITlug docs)

date-end: "2020-01-16 19:00"
location: "MSS-3190"
title: "FOSS Hours"
rrule: "FREQ=WEEKLY;UNTIL=20200423T190000"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the syntax for this frontmatter? I want to link out to documentation about how to write these for future contributors.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jwflory https://github.com/RITlug/ritlug.github.io#calendar--placeholders

Placeholders can also take an rrule frontmatter for recurring events, written to the iCal spec.

Of particular note,

The UNTIL rule part defines a DATE or DATE-TIME value that bounds the recurrence rule in an inclusive manner. If the value specified by UNTIL is synchronized with the specified recurrence, this DATE or DATE-TIME becomes the last instance of the recurrence. The value of the UNTIL rule part MUST have the same value type as the "DTSTART" property.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ct-martin Thanks. I'll use that as a base for the Runbook.

Copy link
Member

@jwflory jwflory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ct-martin. Looks good to me. I opened a few new issues to keep track of the things we discussed here already: FOSSRIT/runbook#43 and #118.

Going to go ahead and merge this! 🌊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new change Adds new capabilities or functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants