-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Calendar page #85
Conversation
Thanks @ct-martin. I'll try to review this by the end of the week. I also requested review by the Tech Team since I am not particularly web-savvy. |
This is essentially verbatim the RITlug website PR that we merged a few days ago. You can see the merged view here. I'll leave it to you guys to approve. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ct-martin, I had a chance to test this today. Looks good! 🎉 I have a few changes I'd like to see before merging:
- Documentation about how to add new events to the calendar in the CONTRIBUTING.md file (appending to the bottom is fine)
- Add link to "Calendar" in the upper-navigation and footer (between "Announcements" and "Events")
Once these are done, I'll merge this PR. Thanks for working on this!
|
Hey @ct-martin, could you please rebase this PR on the latest |
@jwflory done. In particular, please note the |
date-end: "2020-01-16 19:00" | ||
location: "MSS-3190" | ||
title: "FOSS Hours" | ||
rrule: "FREQ=WEEKLY;UNTIL=20200423T190000" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the syntax for this frontmatter? I want to link out to documentation about how to write these for future contributors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jwflory https://github.com/RITlug/ritlug.github.io#calendar--placeholders
Placeholders can also take an
rrule
frontmatter for recurring events, written to the iCal spec.Of particular note,
The UNTIL rule part defines a DATE or DATE-TIME value that bounds the recurrence rule in an inclusive manner. If the value specified by UNTIL is synchronized with the specified recurrence, this DATE or DATE-TIME becomes the last instance of the recurrence. The value of the UNTIL rule part MUST have the same value type as the "DTSTART" property.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ct-martin Thanks. I'll use that as a base for the Runbook.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ct-martin. Looks good to me. I opened a few new issues to keep track of the things we discussed here already: FOSSRIT/runbook#43 and #118.
Going to go ahead and merge this! 🌊
Based on RITlug site calendar. I leave it to you to choose where to link (outside this PR).