Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error locations when using assert_norm are off #1563

Closed
msprotz opened this issue Oct 15, 2018 · 2 comments · Fixed by #3085
Closed

Error locations when using assert_norm are off #1563

msprotz opened this issue Oct 15, 2018 · 2 comments · Fixed by #3085
Assignees
Labels
area/error-messages area/usability easy An easy bug to tackle kind/bug milestone/everest-v1 We expect to solve this issue by the Everest v1 release.

Comments

@msprotz
Copy link
Collaborator

msprotz commented Oct 15, 2018

Compare:

screen shot 2018-10-15 at 4 58 30 pm

with:

screen shot 2018-10-15 at 4 58 40 pm

Thanks,

Jonathan

@mtzguido
Copy link
Member

Ah nice, I've also seen this but didn't know what caused it. Here's a small repro:

module Bug1563

let f (x y z : int) =
  assert_norm (x + x == y + y);
  assert (x + y == y + x);
  42

@nikswamy
Copy link
Collaborator

There's work on this by Qunyan in a branch. I'll try to revive it.

@nikswamy nikswamy self-assigned this Mar 23, 2020
@nikswamy nikswamy added the milestone/everest-v1 We expect to solve this issue by the Everest v1 release. label Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/error-messages area/usability easy An easy bug to tackle kind/bug milestone/everest-v1 We expect to solve this issue by the Everest v1 release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants