Do not unfold logical connectives in norm requests #3085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/ normalize
This keeps better ranges, and the VCs look simpler, since we get stuff
like `a /\ b` instead of `x:unit{pair a b}`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it so that using
assert_normwill not cause excessive normalization, turning e.g.l_and p qintox:unit{pair p q}. This is not terrible (the SMT encoding recognizes the second one to be equivalent to the first), but can affect performance and error reporting. In particular the ranges of the unfolded formula are better, since they have been written by the user, but in the unfolded refinment they are lost (though I'm not sure why...)A single regression in FStar.Classical is fixed by asking to explicitly unfold
l_Forall. This wasn't possible before (UnfoldTacdisabled the unfolding even if explicitly usingdelta_only), but it is now.Fixes #1563