Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require OCaml >= 4.10 #2865

Merged
merged 3 commits into from
Apr 6, 2023
Merged

Require OCaml >= 4.10 #2865

merged 3 commits into from
Apr 6, 2023

Conversation

tahina-pro
Copy link
Member

Johannes Blaser of @vusec reports F* not building on OCaml 4.08:

File "fstar-lib/generated/FStar_Monotonic_Seq.ml", lines 124-132, characters 2-46:
124 | ..fun l ->
125 |     fun max ->
126 |       fun i ->
127 |         fun init ->
128 |           fun log ->
129 |             FStar_HyperStack_ST.recall log;
130 |             FStar_HyperStack_ST.recall_region ();
131 |             FStar_HyperStack_ST.mr_witness () () () (Obj.magic log) ();
132 |             FStar_HyperStack_ST.ralloc () init
Error: This definition has type
         Prims.unit ->
         Prims.nat ->
         Prims.unit ->
         Prims.nat ->
         (Prims.unit, 'a) log_t ->
         (Prims.unit, 'a, Prims.unit, Prims.unit, Prims.unit) seqn
       which is less general than
         'a0.
           Prims.unit ->
           Prims.nat ->
           Prims.unit ->
           Prims.nat ->
           (Prims.unit, 'a0) log_t ->
           (Prims.unit, 'a0, Prims.unit, Prims.unit, Prims.unit) seqn
make: *** [Makefile:23: dune-fstar] Error 1

I can reproduce the same failure with OCaml 4.09. By contrast, OCaml 4.10 succeeds.

So this PR updates the opam package definition and the documentation, and removes some file that was necessary for earlier versions of OCaml.

tahina-pro added a commit to project-everest/everest that referenced this pull request Mar 29, 2023
Karamel already explicitly required OCaml >= 4.10, but that
check was not updated back then. Subsequently, Johannes Blaser
of @vusec used `./everest check` to install
F* with OCaml 4.08 and failed. See FStarLang/FStar#2865
@mtzguido mtzguido merged commit e7d5f75 into master Apr 6, 2023
@mtzguido mtzguido deleted the _taramana_requires_ocaml_4_10 branch April 6, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants