Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
--warn_error
option is accumulated by successive uses, with latter uses overriding the former, hence--warn_error @1..100 --warn_error -50
will ignore error 50, but make 1..49 and 51..100 fatal.However, combinations within a single
--warn_error
option use have the order reversed, the equivalent to the above is--warn_error [email protected]
.This PR changes that, so the order within a single invocation is left-to-right as for separate invocations, and hence
--warn_error A --warn_error B
is the same as--warn_error AB
. Earlier settings are overridden by latter ones (i.e. to the right, or more deeply nested within#push-options
).Motivated by #2950