deep_compress: remove some spurious warnings about Tm_names #3025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deep_compress warned on reaching a Tm_name (when allow_uvars was false) since they are not meant to be saved into checked files (as they are a leak). However we are now using deep_compress more pervasively to check that terms do not contain uvars, but in situations where names are totally OK, such as the reflection API. So, add a new toggle for deep_compress and make it not warn on Tm_names in these cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deep_compress warned on reaching a Tm_name (when allow_uvars was false)
since they are not meant to be saved into checked files (as they are a
leak). However we are now using deep_compress more pervasively to check
that terms do not contain uvars, but in situations where names are
totally OK, such as the reflection API.
So, add a new toggle for deep_compress and make it not warn on Tm_names
in these cases.